Skip to content

Remove legacy viewTest.php page #3731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
williamjallen merged 1 commit into from
May 15, 2026
Merged

Remove legacy viewTest.php page #3731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/cdash/app/Model/Build.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2239,7 +2239,7 @@ public function GetBuildErrorUrl(): string

public function GetTestUrl(): string
{
return url('/viewTest.php') . "?buildid={$this->Id}";
return url("/builds/{$this->Id}/tests");
}

public static function ConvertMissingToZero($value): int
Expand Down
1 change: 0 additions & 1 deletion app/cdash/tests/autoremovebuilds/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ set_property(TEST deletesubproject PROPERTY DEPENDS
cypress/e2e/manage-overview
cypress/e2e/manage-build-group
cypress/e2e/manage-sub-project
cypress/e2e/view-test
cypress/e2e/sort-index
cypress/e2e/expected-build
cypress/e2e/remove-build
Expand Down
2 changes: 1 addition & 1 deletion phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23562,7 +23562,7 @@ parameters:
-
rawMessage: 'Part $buildid (array|string|null) of encapsed string cannot be cast to string.'
identifier: encapsedStringPart.nonString
count: 7
count: 8
path: routes/web.php

-
Expand Down
148 changes: 0 additions & 148 deletions resources/js/angular/controllers/viewTest.js
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions resources/js/angular/legacy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,6 @@ CDash.controller('SubProjectController', ["$scope", "$rootScope", "$http", SubPr
import { QueryTestsController } from "./controllers/queryTests";
CDash.controller('QueryTestsController', ["$scope", "$rootScope", "$filter", "apiLoader", "filters", "multisort", QueryTestsController]);

import { ViewTestController } from "./controllers/viewTest";
CDash.controller('ViewTestController', ["$scope", "$rootScope", "$http", "$filter", "$q", "apiLoader", "multisort", "filters", ViewTestController]);

import { OverviewController, linechart, bulletchart } from "./controllers/overview";
CDash.controller('OverviewController', ["$scope", "$location", "anchors", "apiLoader", OverviewController]);
CDash.directive('linechart', linechart);
Expand Down
1 change: 0 additions & 1 deletion resources/js/vue/components/ProjectSettings/TestMeasurementsTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@
Add test measurements of type <span class="tw-font-mono">numeric/double</span> or <span class="tw-font-mono">text/string</span>. Any measurement added here will be displayed as an extra column on the following pages:
<ul class="tw-list-circle tw-ml-4">
<li><span class="tw-font-mono">queryTests.php</span></li>
<li><span class="tw-font-mono">viewTest.php</span></li>
<li><span class="tw-font-mono">builds/&lt;id&gt;/tests</span></li>
</ul>
</li>
Expand Down
Loading