Fix Privacy Policy heading/date overlap - #4
Merged
Merged
Conversation
.meta had a -24px top margin left over from an earlier layout experiment, pulling the 'Last updated' line up into the h1 and causing visible text overlap on the privacy pages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
On the FreeSlots and Sundown Privacy Policy pages, the "Last updated" line rendered on top of the "Privacy Policy" heading (see screenshot in conversation).
Cause
`.meta` in `public/apps/apps.css` had a leftover `margin-top: -24px` from an earlier layout experiment, pulling the date line up into the `
`'s line box.
Fix
Removed the negative top margin (`margin: -24px 0 32px` → `margin: 0 0 32px`).
Note
mainanddevelopare both currently at the same commit (post PR #2/#3), so this should be merged here and then forwarded tomainthe same way PR #3 was.Verification
`npm run build` succeeds; confirmed via CSS box-model math that `.meta` no longer overlaps `h1` (h1: 32px/1.2 line-height + 4px margin-bottom, followed immediately by non-negative `.meta` margin).