HDU lookup: use primary_hdu instead of 'SCI' (fix for banzai-floyds) - #496
Merged
Merged
Conversation
timbeccue
requested review from
cmccully and
jchate6
and removed request for
jchate6
September 29, 2026 07:33
cmccully
approved these changes
Sep 29, 2026
cmccully
left a comment
cmccully
left a comment
Collaborator
There was a problem hiding this comment.
Previously, we had hardcoded the 'SCI' extension in some places and it should instead use the frame method primary_hdu (which is more dynamic) to select the data we want to work with.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 1.38.0, #469 changed init_master_frame and CalibrationStacker to look up an HDU named 'SCI' instead of using the primary HDU. This caused issues in Floyds because some of the tests build fits images that don't have an HDU named 'SCI' LCOGT/banzai-floyds#106.
In banzai and banzai-floyds, using primary_hdu instead of 'SCI' seems to work without issue, and that fixes the problem in floyds. I tested this against banzai-floyds and banzai-nres pointed at this branch, and the failing unit tests related to the primary HDU now pass.
This PR also bumps the version to 1.39.1 so it can be used with banzai-floyds.