Bump HarmonyX to 2.16.0#1091
Open
BennyDioxide wants to merge 8 commits intoLavaGang:alpha-developmentfrom
Open
Bump HarmonyX to 2.16.0#1091BennyDioxide wants to merge 8 commits intoLavaGang:alpha-developmentfrom
BennyDioxide wants to merge 8 commits intoLavaGang:alpha-developmentfrom
Conversation
Along with related dependencies
Author
|
In newer |
As DetourHelper is gone, and they removed the Process.Start check from platform detection as well, this can be removed.
New API equivalents
The MonoMod API changed a lot, which's the time to remove back compatibilities
The upstream Harmony moved it to internal
New MonoMod decided to bundle their own version of Iced of whatever reason
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benefits: osx-arm64 (Apple Silicon) support, .Net 10
Problems to be addressed:
HarmonyX supports osx-arm64 via MonoMod/MonoMod#241, so MonoMod should be updated as well. But since they do a great amount of rewrite, things would be hugely complicated:
MonoMod.RuntimeDetoursystem has been rewrited, making detours no longer haveOnDetourto hook on andPatchShieldandInstancePatchFixthus stop blockingRuntimeDetourhooks.MonoMod.RuntimeDetour.DetourHelperis gone,DetourHelper::PinandDetourHelper::GetNativeStartno longer worksMonoMod.RuntimeDetournow bundles its ownMonoMod.IcedthroughMonoMod.Core, making lots of conflicts