Fallback to existing Il2Cpp assemblies when generation fails#1153
Closed
Sim-hu wants to merge 1 commit into
Closed
Fallback to existing Il2Cpp assemblies when generation fails#1153Sim-hu wants to merge 1 commit into
Sim-hu wants to merge 1 commit into
Conversation
Author
Member
|
When assembly generation fails there is usually a very good reason for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
ForceRegenerationstill fails instead of falling backWhy
Some games can fail regeneration after an update, while previously generated assemblies are still present and good enough for MelonLoader to start. Currently generation failure aborts startup even when those assemblies are available.
Testing
dotnet build MelonLoader.sln -c ReleaseMelonLoader/Il2CppAssembliesallows startup when generation is skipped.