Conversation
…gate Fixes verified out of the DAG self-review (workflow dag_04df6bfa6ffe): - capture: enforce JSON Schema type arrays (H1 — typeof guard skipped validation entirely for ["string","null"]) plus scalar constraints (min/max, length, pattern, item counts, additionalProperties:false); warn at create/replan on keywords the subset validator ignores - recovery: enforce the review-result contract on crash-recovered diff reviews (B1 — recovery bypassed spawn's completion gate, letting an unvalidated verdict/stale fingerprint through the deep-mode gate) - eval: numeric comparisons fail loudly on non-finite operands instead of silently evaluating false and cascading condition_false skips (B3) - spawn: pre-admission failures settle once and return an empty fiber instead of Effect.fail, removing the duplicate guard-rejected NodeFailed from loop's catchCause (B5) - settlement converged: spawn and recovery both decide structured-output completion through capture.ts settleCapturedOutput, so the review contract cannot drift between the two paths again Root cause of B1: validateReviewResult had exactly one call site (spawn) while recovery re-settled captured output independently — two settlement points, one contract.
fix(dag): close verified self-review findings with shared settlement gate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promote dev to main: verified DAG self-review fixes with shared settlement gate (PR #150).
Contents
validateAgainstSchemaenforces JSON Schema type arrays;type:"null"enforcedsettleCapturedOutputis the single settlement decision shared by spawn and recoveryVerification (already green on dev @ 1c9d88e)
dag-review-audit-regressions.test.ts