Conversation
- recoverWorkflow: synchronous recovering-set reservation makes adoption idempotent across the startup scan and the WorkflowReplanned re-adoption path; a rejected recovery pause now abandons adoption instead of dying - workflow-control handlers (paused/stepped/resumed) cross-check the durable row under the evalLock before mutating runtime flags; the stepped handler refuses to spawn while a node is in flight, and Dag.step counts queued admissions as in-flight - per-workflow lock convention is now type-enforced: guarded commands take a WorkflowLock witness only withWorkflowLock can mint - lint ratchet 4690 -> 4711 (new test harness as-never idioms + witness mint)
fix(dag): close adoption, stepping and lock-witness race windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes dev to main with the DAG audit fixes from #152:
recoverWorkflowadoption idempotency (synchronous reservation; no duplicate reconcile / entry overwrite / orphaned fibers)evalLock;Dag.stepcounts queued as in-flightWorkflowLockwitnessRegression tests:
test/dag/dag-adoption-step-races.test.ts(verified failing pre-fix, passing post-fix). Local: opencode dag 305/305, core dag 89/89, typecheck ×2 green. No schema / API / SDK changes.