Conversation
…completion The idle-escape threshold in RunStreamTransport.poll resolved the turn's deferred as success after 8 consecutive idle reads, reporting a turn that never ran as an ordinary empty success — a silent wrong answer worse than the hang the escape exists to break. Fail the deferred with a diagnostic error instead, scoped to this turn only (state.fault would poison every later prompt on the transport). Also raise the threshold from 8 to 40 ticks (2s → 10s) to widen the margin over the admission-to-busy latency. workflows.ts: drop the config.name → title fallback. name is a config field distinct from Entry.name (the filename); using it as a title fallback conflated two concepts and made the title source ambiguous.
fix(stream): fail idle-escape turn with diagnostic instead of silent completion
The previous dev run's Unit Tests (linux) hung at the HttpAPI Exerciser worktree.create step and was cancelled; the cancelled conclusion is blocking PR #159's merge into main even though the PR's own CI passed all required checks. Empty commit to force a fresh green run.
chore(ci): retrigger dev CI to clear stale cancelled check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the idle-escape in
RunStreamTransport.pollto fail a turn with a diagnostic error instead of silently reporting it as a successful empty turn when the server never starts a drain. Also raises the threshold from 2s to 10s. Companion cleanup inworkflows.tsdrops theconfig.name → titlefallback that conflated two distinct concepts.Fixes the only verified finding from the post-merge review (H3 mechanism confirmed, failure-mode quality upgraded). C1 (worker.fatal postMessage) was empirically disproved — see PR #158 body for the 3/3 Bun worker reproduction.
CI: Typecheck + Unit Tests + E2E (linux + windows) gates apply.