feat(vscode): #2869 plugin updates (merged with main + lockfile fix) - #28
Open
LeighFinegold wants to merge 20 commits into
Open
feat(vscode): #2869 plugin updates (merged with main + lockfile fix)#28LeighFinegold wants to merge 20 commits into
LeighFinegold wants to merge 20 commits into
Conversation
…actFlow Major rewrite of the VS Code extension from Mermaid-based preview to a full visual architecture editor: - Interactive ReactFlow canvas for editing CALM architectures - Drag-and-drop node palette with workspace building blocks - Standards/guidelines drag-onto-node with dotted "adheres to" edges - Edge direction (unidirectional, bidirectional, none) and line styles - Theme-aware UI following VS Code light/dark/high-contrast themes - Real-time bidirectional sync between JSON editor and canvas - Validation panel with clickable issues - Drill-down navigation into building blocks with breadcrumbs - SVG export, pattern application, and spec generation - Configurable extension packs (calm.packs.enabled, calm.packs.excludeNodes) - Edge metadata (key-value pairs) support
The vscode plugin PR added new dependencies (vite, @dagrejs/dagre, elkjs, lucide-react, ajv-formats, etc.) to calm-plugins/vscode/package.json but the root package-lock.json was not regenerated, so 'npm ci' fails in CI. Regenerated the lockfile from a clean install (rm -rf node_modules package-lock.json && npm install) on Node 26, preserving all platform-specific optional binaries.
The vscode plugin rewrite deleted calm-plugins/vscode/screenshots/, but the build-vscode-screenshots.yml workflow remained. It triggers on changes under that path and fails because its working-directory no longer exists. Removing the orphaned workflow.
Regenerating the lockfile let @docusaurus/theme-mermaid drift to 3.10.2, pulling a second @docusaurus/core + theme-common tree that mismatched the 3.10.1 tree used by the docs preset. This broke 'docs' build with 'useTitleFormatterContext called outside <TitleFormatterProvider>'. Added overrides pinning @docusaurus/core, theme-common and theme-mermaid to 3.10.1 to match upstream main (single consistent tree; faster stays 3.10.2 as on main).
The plugin rewrite removed the test/integration harness and the 'test:integration' script, so the integration-test matrix job failed with 'Missing script: test:integration'. Removed the job and updated package-and-publish needs accordingly.
The rewrite changed the 'package' script to run 'vsce package' without first building, and dropped the 'vscode:prepublish' hook. As a result 'package:vscode' produced no dist/extension.js and vsce failed with 'Extension entrypoint(s) missing'. Restored 'npm run build &&' in the package script and re-added the standard vscode:prepublish hook (matching pre-rewrite behaviour).
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Equivalent of finos#2912 (byrash's CALM Canvas VS Code plugin rewrite), merged with latest
mainand with build fixes on top. Parked on my fork for now.All of byrash's commits are retained. Created via
git worktreeoff the PR head, merged with latestmain, fixes added on top. CI is green.Commits
mainfix(deps): regenerate lockfile for vscode plugin dependenciesci(vscode): remove dead screenshots workflowfix(deps): pin docusaurus runtime packages to 3.10.1ci(vscode): drop integration-test job for removed harnessfix(vscode): build extension before packagingFixes
Lockfile out of sync. The rewrite added new deps to
calm-plugins/vscode/package.json(vite,@dagrejs/dagre,elkjs,lucide-react,ajv-formats, and others) but the rootpackage-lock.jsonwas never regenerated, so CI'snpm cifailed. Regenerated viarm -rf node_modules package-lock.json && npm installon Node 26, preserving all platform-specific optional binaries (rollup/oxide/swc/esbuild Linux variants intact forvalidate-lockfile).docsbuild (useTitleFormatterContext called outside <TitleFormatterProvider>). Regenerating the lockfile let@docusaurus/theme-mermaiddrift to3.10.2, pulling a second@docusaurus/core+theme-commontree that mismatched the3.10.1tree used by the docs preset. Added overrides pinning@docusaurus/core,theme-common, andtheme-mermaidto3.10.1(single consistent tree, matchingmain;fasterstays3.10.2as onmain).VS Code packaging (
Extension entrypoint(s) missing). The rewrite changed thepackagescript to runvsce packagewithout building first and dropped thevscode:prepublishhook, sodist/extension.jsdid not exist at package time. Restorednpm run build &&in thepackagescript and re-addedvscode:prepublish(matching pre-rewrite behaviour).Orphaned CI. The rewrite deleted
calm-plugins/vscode/screenshots/and thetest/integrationharness (plus thetest:integrationscript), but the workflows still referenced them:build-vscode-screenshots.ymlworkflow, because itsworking-directory(calm-plugins/vscode/screenshots) no longer exists so every run failed before doing any work.integration-testmatrix job frombuild-vscode-extension.ymland dropped it frompackage-and-publish'sneeds, because the job invoked the now-deletedtest:integrationscript and could only fail withMissing script, which also blocked the packaging job that depended on it.Verification (Node 26)
npm ci: pass (was failing)docsbuild: passpackage:vscode: produces.vsixNote: PR only touches
calm-plugins/plus the root lockfile/overrides and two VS Code CI workflows. Pre-existing docs/calm-guard/calm-studio issues onmainare unrelated.