Repository navigation
chore: prepare 0.3.0 with Arkworks 0.6 - #39
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare
groth16-solana0.3.0 and upgrade its direct Arkworks dependencies to 0.6. The minor release reflects breaking public API changes since 0.2.0, including verifying-key field changes and removed error variants and trait implementations.Keep the optional Circom conversion API working by reading circom-prover's integer coordinates into validated Arkworks 0.6 points. Remove the direct ark-groth16 dependency, which this conversion no longer needs. Upstream circom-prover and the host Solana BN254 implementation still bring in Arkworks 0.5 transitively.
Add six conversion tests covering fixed output bytes, infinity, invalid coordinates, and points off the curve. Regenerate benchmarks and sync the README: standard Groth16 costs are unchanged; BSB22 costs increase by 2 CU per proof.
Validation passed:
Host checks used the installed macOS 26.5 SDK to avoid a local linker incompatibility with the macOS 27 SDK.