hal: Update mainly C components to getter/setter. - #4324
Merged
Conversation
grandixximo
reviewed
Aug 3, 2026
BsAtHome
force-pushed
the
halgs_components-simple-5
branch
from
August 3, 2026 08:22
c743ac1 to
670094a
Compare
grandixximo
reviewed
Aug 3, 2026
BsAtHome
force-pushed
the
halgs_components-simple-5
branch
from
August 3, 2026 09:15
670094a to
bc02955
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next set of components upgraded to getter/setter. Quite straight forward.
Both demux_generic.c and mux_generic.c have removed the distinction between FP/non-FP thread function export. All threads are FP and we can make it easier. The implementation is no a all-to-all version (except is still does not have 64-bit pins). The magic numbers have been replaced with a macro.
The max31855.comp has had the
floattypes replaced withrtapi_real(effectively double), which means that a numeric difference can occur at 5..6 decimals. However, I don't believe that this stuff can measure temperatures at those levels, so it should be academic.In pwmgen.c several pins are now cached because they were read quite often. This should all work as expected. There are several more optimizations possible, but that is for another time.