feat: Cleanup Qt-based tray implementation#121

Open

Kishi85 wants to merge 28 commits into

LizardByte:masterfrom

Kishi85:simplify-qt-tray

Commits on May 19, 2026

Import adapted QtTrayMenu class from upstream
Kishi85
committed
Integrate upstream QtTrayMenu.h/cpp into tray_linux.cpp
Kishi85
committed
doc: Add doxygen comments for public functions of QtTrayMenu
Kishi85
committed
fix: Add default initialized values and change running state tracking
Kishi85
committed
Add support for spectacle screenshots on KDE
Kishi85
committed
Revert example to non-notification variant
Kishi85
committed
fix: Segfaults from unit tests
Kishi85
committed
WIP - process events during exit
Kishi85
committed
Update test_tray.cpp

ReenigneArcher
authored and
Kishi85
committed
Provide default argv, hide menu, use popup

ReenigneArcher
authored and
Kishi85
committed
QApplication::quit() only for apps that we created.
Kishi85
committed
Cleanup QtTrayMenu constructor
Kishi85
committed
Add option to fire notification using QSystemTray::showMessage on init/update
Kishi85
committed
(Re-)Implement tray notifications using libnotify with fallback to basic QtTrayIcon::showMessage()
Kishi85
committed
Refactor tray_linux.cpp notifications and add separate namespace for tray_linux
Kishi85
committed
fix: Properly cleanup notificationCurrent and notificationCurrentCallback where necessary
Kishi85
committed
refactor - Use acknowledge_notification to also clear previous notification in notify()
Kishi85
committed
fix: Allow using themed icons for tray icon
Kishi85
committed
fix: Always use absolute paths for filesystem-based notification icons
Kishi85
committed
fix: Add missing/fix docstrings and unify variable style for namespace tray_linux
Kishi85
committed
fix: Remove Qt::DBus dependency
Kishi85
committed
fix: Fix potential issues with QtTrayMenu
Kishi85
committed
fix: Re-init notify upon setting app_name
Kishi85
committed
fix: Process UI modifications using Qt event system
Kishi85
committed
fix: Improve error handling on tray_init
Kishi85
committed
tests: Increase delay for screenshot capture to 2000ms
Kishi85
committed
fix: Only fail tray init on libnotify failure if Qt does not support messages on system tray
Kishi85
committed
fix: Requested changes from review
Kishi85
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Cleanup Qt-based tray implementation#121

feat: Cleanup Qt-based tray implementation#121
Kishi85 wants to merge 28 commits into
LizardByte:masterfrom
Kishi85:simplify-qt-tray

Commits on May 19, 2026

Import adapted QtTrayMenu class from upstream

Integrate upstream QtTrayMenu.h/cpp into tray_linux.cpp

doc: Add doxygen comments for public functions of QtTrayMenu

fix: Add default initialized values and change running state tracking

Add support for spectacle screenshots on KDE

Revert example to non-notification variant

fix: Segfaults from unit tests

WIP - process events during exit

Update test_tray.cpp

Provide default argv, hide menu, use popup

QApplication::quit() only for apps that we created.

Cleanup QtTrayMenu constructor

Add option to fire notification using QSystemTray::showMessage on init/update

(Re-)Implement tray notifications using libnotify with fallback to basic QtTrayIcon::showMessage()

Refactor tray_linux.cpp notifications and add separate namespace for tray_linux

fix: Properly cleanup notificationCurrent and notificationCurrentCallback where necessary

refactor - Use acknowledge_notification to also clear previous notification in notify()

fix: Allow using themed icons for tray icon

fix: Always use absolute paths for filesystem-based notification icons

fix: Add missing/fix docstrings and unify variable style for namespace tray_linux

fix: Remove Qt::DBus dependency

fix: Fix potential issues with QtTrayMenu

fix: Re-init notify upon setting app_name

fix: Process UI modifications using Qt event system

fix: Improve error handling on tray_init

tests: Increase delay for screenshot capture to 2000ms

fix: Only fail tray init on libnotify failure if Qt does not support messages on system tray

fix: Requested changes from review