Report the signature algorithm's S-pair queue by name, not as "todo" - #93
Merged
Merged
Conversation
ConcreteSigSPairQueue::name() was a placeholder never filled in, so every mgb sig run printed S-pair queue type: todo The class wraps a mathic::PairQueue exactly as SPairs does for the classic algorithm, and SPairs::name() returns the queue's own name, so this does the same. mgb sig now prints S-pair queue type: PairQueue-t-tree (si) matching mgb gb. PairQueue::name() is what SPairs already calls, so this needs nothing new from mathic. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every
mgb sigrun printedConcreteSigSPairQueue::name()was a placeholder,{return "todo";}, that wasnever filled in.
The class wraps a
mathic::PairQueueexactly asSPairsdoes for the classicalgorithm, and
SPairs::name()simply returns the queue's own name. Thisdoes the same, so
mgb signow printswhich matches what
mgb gbreports.PairQueue::name()is the callSPairsalready makes, so this needs nothing new from mathic.Verification
mgb sigoncyclic5prints the line above.todostring.No test is added: the text comes from mathic, so asserting it would tie a
mathicgb test to mathic's wording, and no test checks
SPairs::name()either.🤖 Generated with Claude Code