Skip to content

Change pagefind output to _markbind/logs #2897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Harjun751 merged 5 commits into from
May 31, 2026
Merged

Change pagefind output to _markbind/logs #2897

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e203ce7
Change pagefind output to _markbind/logs
yihao03 Apr 27, 2026
8554805
Update log file name
yihao03 Apr 27, 2026
3e10733
Update tests
yihao03 Apr 27, 2026
8785752
Construct log folder path from output folder path
yihao03 Apr 27, 2026
d20af87
Fixes
yihao03 Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/core/src/Site/SiteGenerationManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -881,12 +881,13 @@ export class SiteGenerationManager {
try {
const { createIndex, close } = pagefind;

const logsPath = path.join(this.rootPath, '_markbind', 'logs');
const pagefindConfig = this.siteConfig.pagefind || {};

const createIndexOptions: Record<string, unknown> = {
keepIndexUrl: true,
verbose: true,
logfile: 'debug.log',
logfile: path.join(logsPath, 'pagefind.log'),
};
Comment thread
yihao03 marked this conversation as resolved.

if (pagefindConfig.exclude_selectors) {
Expand Down
6 changes: 3 additions & 3 deletions packages/core/test/unit/Site/SiteGenerationManager.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ describe('SiteGenerationManager', () => {
expect(pagefindSpy).toHaveBeenCalledWith({
keepIndexUrl: true,
verbose: true,
logfile: 'debug.log',
logfile: path.join('/tmp/test', '_markbind', 'logs', 'pagefind.log'),
});
Comment thread
yihao03 marked this conversation as resolved.

pagefindSpy.mockRestore();
Expand Down Expand Up @@ -167,7 +167,7 @@ describe('SiteGenerationManager', () => {
expect(pagefindSpy).toHaveBeenCalledWith({
keepIndexUrl: true,
verbose: true,
logfile: 'debug.log',
logfile: path.join('/tmp/test', '_markbind', 'logs', 'pagefind.log'),
excludeSelectors: ['.no-index', '#sidebar'],
});
Comment thread
yihao03 marked this conversation as resolved.

Expand Down Expand Up @@ -311,7 +311,7 @@ describe('SiteGenerationManager', () => {
{ pageConfig: { resultPath: path.join(outputPath, 'page2.html'), searchable: true } },
] as any;

await generationManagerOnePage.indexSiteWithPagefind();
await generationManagerOnePage.indexSiteWithPagefind('/tmp/test/_markbind/logs');
Comment thread
yihao03 marked this conversation as resolved.
Outdated

expect(mockIndex.addHTMLFile).toHaveBeenCalledTimes(1);
expect(mockIndex.addHTMLFile).toHaveBeenCalledWith({
Expand Down
Loading