Historical Currencies with support for ZWG - #1
Open
imarjanovic wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extends on Max's PR into the main repo by adding support for ZWG. The intention is to, for now, pull this into MWB via Github, so that we can both parse new and old currencies (one of which we'd lose by upgrading to the latest version in the
masterbranch of thechordifyrepo). Eventually, we may want to push on getting some fix into the mainline repo or hard-fork this library for internal use, but updates to currencies are pretty sporadic, so this should buy us quite a bit of time to figure that out.