-
Notifications
You must be signed in to change notification settings - Fork 2
Add running the unittests to the GitHub workflow #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 10 commits
c6f04fe
4d2c3be
53a6163
05b158e
b3d7579
81db099
68cd5c9
7e32edd
1edde1d
d7a4213
06ae314
9853ca9
4c8ed64
3a9d45a
1b766ff
cc5ebb8
8f0db29
d70e7de
4e0b916
96a62b6
528024a
8836fda
17dca6a
de8d97d
6fda3d8
cecaec7
feb3d1e
581af08
1bca788
c6114c3
fe6953e
119b6dc
3fc8305
1859b12
59e3a6c
1b49c65
e422473
2fc7f4d
6a17f12
ced2bb3
6e0e98e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| # (C) Crown Copyright 2022-2025, Met Office. | ||
| # (C) Crown Copyright 2022-2026, Met Office. | ||
| # The LICENSE.md file contains full licensing details. | ||
| # This workflow creates the required Conda environment, performs various | ||
| # validation steps for Cylc and Rose, and builds and checks the documentation. | ||
|
|
@@ -67,6 +67,11 @@ jobs: | |
| cd CMEW | ||
| rose metadata-check -C meta/ | ||
|
|
||
| - name: Run Cylc unit tests | ||
| run: | | ||
| cd CMEW | ||
| conda run -n cmew cylc vip -O metoffice -O unittest . | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there an advantage to running the tests via the cylc workflow, as opposed to just running the same pytest command as the unittest app?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We are still running tests via the Cylc Workflow. With |
||
|
|
||
| - name: Build documentation | ||
| run: | | ||
| eval "$(conda shell.bash hook)" | ||
|
|
@@ -93,3 +98,10 @@ jobs: | |
| run: | | ||
| find . -type f \( -name "*.sh" -or -name "*-env$" \) \ | ||
| -exec shellcheck {} \; | ||
|
|
||
| - name: Upload cylc-run logs on failure | ||
| if: failure() | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: cylc-run-logs | ||
| path: ~/cylc-run | ||
|
ehogan marked this conversation as resolved.
Outdated
|
||
Uh oh!
There was an error while loading. Please reload this page.