Skip to content
Open
Changes from 10 commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
c6f04fe
add unitests in github workflow
zmaalick Jan 8, 2026
4d2c3be
update with changess suggested by nik #165
zmaalick Jan 9, 2026
53a6163
remove logging block
zmaalick Jan 9, 2026
05b158e
change validate to vip
zmaalick Jan 9, 2026
b3d7579
revert back the changes
zmaalick Jan 9, 2026
81db099
add logging block
zmaalick Jan 9, 2026
68cd5c9
end of file line
zmaalick Jan 9, 2026
7e32edd
unittest block changes
zmaalick Jan 9, 2026
1edde1d
Merge branch 'main' into 165_add_unittest_in_github_workflow
alistairsellar Jan 12, 2026
d7a4213
update copywrite year
zmaalick Jan 12, 2026
06ae314
update unittest with pytest
zmaalick Jan 12, 2026
9853ca9
add pytest in env
zmaalick Jan 12, 2026
4c8ed64
fix pytest
zmaalick Jan 12, 2026
3a9d45a
add pytest in yml
zmaalick Jan 12, 2026
1b766ff
add pluggy in lock
zmaalick Jan 12, 2026
cc5ebb8
update lock
zmaalick Jan 13, 2026
8f0db29
add esmvalcore
zmaalick Jan 13, 2026
d70e7de
fix linter issue and make consistancy in pytest call
zmaalick Jan 13, 2026
4e0b916
remove logging section and update yml file
zmaalick Jan 13, 2026
96a62b6
reorder the env packages list alphabetically
zmaalick Jan 15, 2026
528024a
update the copywrite
zmaalick Jan 15, 2026
8836fda
remove ignore in lint and update execution limit in metoffice.cylc
zmaalick Jan 15, 2026
17dca6a
add pytest conf file and update github actions
zmaalick Jan 15, 2026
de8d97d
declaration correct in pytest conf
zmaalick Jan 15, 2026
6fda3d8
add pytest mark
zmaalick Jan 15, 2026
cecaec7
update with pytest mark
zmaalick Jan 15, 2026
feb3d1e
remove marking for pytest
zmaalick Jan 16, 2026
581af08
move pytest conf in pyproj and update pytest command in actions
zmaalick Jan 20, 2026
1bca788
updated the suggested changes
zmaalick Jan 21, 2026
c6114c3
pre-commit changes
zmaalick Jan 21, 2026
fe6953e
revert back the copywrite change
zmaalick Jan 23, 2026
119b6dc
revert back the change
zmaalick Jan 23, 2026
3fc8305
revert the copywrite change
zmaalick Jan 27, 2026
1859b12
add pytest.ini
zmaalick Feb 3, 2026
59e3a6c
add unittest solution
zmaalick Feb 3, 2026
1b49c65
hook changes
zmaalick Feb 3, 2026
e422473
update copywrites
zmaalick Feb 3, 2026
2fc7f4d
fix rose-dump error
zmaalick Feb 3, 2026
6a17f12
update unittest rose conf
zmaalick Feb 9, 2026
ced2bb3
fix type
zmaalick Feb 9, 2026
6e0e98e
rename pytest.ini
zmaalick Mar 6, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion .github/workflows/default.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# (C) Crown Copyright 2022-2025, Met Office.
# (C) Crown Copyright 2022-2026, Met Office.
# The LICENSE.md file contains full licensing details.
# This workflow creates the required Conda environment, performs various
# validation steps for Cylc and Rose, and builds and checks the documentation.
Expand Down Expand Up @@ -67,6 +67,11 @@ jobs:
cd CMEW
rose metadata-check -C meta/

- name: Run Cylc unit tests
Comment thread
ehogan marked this conversation as resolved.
Outdated
run: |
cd CMEW
conda run -n cmew cylc vip -O metoffice -O unittest .

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an advantage to running the tests via the cylc workflow, as opposed to just running the same pytest command as the unittest app?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are still running tests via the Cylc Workflow. With 'conda run -n cmew cylc vip ....' and in GitHub Actions it is often more reliable (fewer shell and activation surprises). It was already mentioned in the review: 'This eliminates shell activation issues and is more reliable in Actions'.


- name: Build documentation
run: |
eval "$(conda shell.bash hook)"
Expand All @@ -93,3 +98,10 @@ jobs:
run: |
find . -type f \( -name "*.sh" -or -name "*-env$" \) \
-exec shellcheck {} \;

- name: Upload cylc-run logs on failure
if: failure()
uses: actions/upload-artifact@v4
with:
name: cylc-run-logs
path: ~/cylc-run
Comment thread
ehogan marked this conversation as resolved.
Outdated