Skip to content

CH-290 Fix -ex filter being injected as -i in codefresh config - #865

Merged
filippomc merged 2 commits into
developfrom
feature/CH-290
Sep 3, 2026
Merged

CH-290 Fix -ex filter being injected as -i in codefresh config#865
filippomc merged 2 commits into
developfrom
feature/CH-290

Conversation

@aranega

@aranega aranega commented Sep 3, 2026

Copy link
Copy Markdown
Member

Closes CH-290

Implemented solution

The PR fixes an old bug where -ex parameters were wrongly injected in the codefresh configuration as a -i parameter. The problem came from a bad copy/paste where the -i parameter was repeated instead of -ex.

How to test this PR

Use the harness-deployment with any -ex explicit parameter (e.g.: -ex foo on the command line. Without the fix, in the codefresh configuration, -i foo will appear while -ex foo will appear with the fix.

Sanity checks:

  • The pull request is explicitly linked to the relevant issue(s)
  • The issue is well described: clearly states the problem and the general proposed solution(s)
  • In this PR it is explicitly stated how to test the current change
  • The issue seta the scope and the type of issue (bug, story, task, etc.)
  • The relevant components are indicated in the issue (if any)
  • All the automated test checks are passing
  • All the linked issues are included in one Sprint
  • All the linked issues are in the Review state
  • All the linked issues are assigned

Breaking changes (select one):

  • The present changes do not change the preexisting api in any way
  • This PR and the issue are tagged as a breaking-change and the migration procedure is well described above

Possible deployment updates issues (select one):

  • There is no reason why deployments based on CloudHarness may break after the current update
  • This PR and the issue are tagged as alert:deployment

Test coverage (select one):

  • Tests for the relevant cases are included in this pr
  • The changes included in this pr are out of the current test coverage scope

Documentation (select one):

  • The documentation has been updated to match the current changes
  • The changes included in this PR are out of the current documentation scope

Nice to have (if relevant):

  • Screenshots of the changes
  • Explanatory video/animated gif

@aranega
aranega requested a review from filippomc September 3, 2026 09:50
@aranega aranega added the bug Something isn't working label Sep 3, 2026
Comment thread tools/deployment-cli-tools/ch_cli_tools/codefresh.py Fixed
Leftover I forgot to remove

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
@filippomc
filippomc merged commit a09cc1a into develop Sep 3, 2026
10 of 11 checks passed
@filippomc
filippomc deleted the feature/CH-290 branch September 3, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants