Skip to content

CH-291 Harmonize yaml libraries and formatting - #868

Open
filippomc wants to merge 1 commit into
developfrom
feature/CH-291-yaml-formatting
Open

CH-291 Harmonize yaml libraries and formatting#868
filippomc wants to merge 1 commit into
developfrom
feature/CH-291-yaml-formatting

Conversation

@filippomc

@filippomc filippomc commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Closes CH-291

Implemented solution

ruamel.yaml is used everywhere now and configured, instead of base yaml and oyaml.

How to test this PR

Run harness-deployment. It should work and the file should be formatted like

a:
  b: b
  c: c

not

a: { b: b,  c: c }

Sanity checks:

  • The pull request is explicitly linked to the relevant issue(s)
  • The issue is well described: clearly states the problem and the general proposed solution(s)
  • In this PR it is explicitly stated how to test the current change
  • The issue seta the scope and the type of issue (bug, story, task, etc.)
  • The relevant components are indicated in the issue (if any)
  • All the automated test checks are passing
  • All the linked issues are included in one Sprint
  • All the linked issues are in the Review state
  • All the linked issues are assigned

Breaking changes (select one):

  • The present changes do not change the preexisting api in any way
  • This PR and the issue are tagged as a breaking-change and the migration procedure is well described above

Possible deployment updates issues (select one):

  • There is no reason why deployments based on CloudHarness may break after the current update
  • This PR and the issue are tagged as alert:deployment

Test coverage (select one):

  • Tests for the relevant cases are included in this pr
  • The changes included in this pr are out of the current test coverage scope

Documentation (select one):

  • The documentation has been updated to match the current changes
  • The changes included in this PR are out of the current documentation scope

Nice to have (if relevant):

  • Screenshots of the changes
  • Explanatory video/animated gif

With this, we are also harmonizing formatting
@filippomc
filippomc requested a review from aranega September 4, 2026 11:10
assert 'cloudharness-base-debian' not in values[KEY_TASK_IMAGES]

chart_values = yaml.safe_load(open(helm_path / 'charts/myapp/values.yaml', 'r')) # Check if the values.yaml is valid YAML
chart_values = yaml.load(open(helm_path / 'charts/myapp/values.yaml', 'r')) # Check if the values.yaml is valid YAML

chart_path = out_folder / HELM_CHART_PATH / 'Chart.yaml'
chart = yaml.safe_load(open(chart_path, 'r'))
chart = yaml.load(open(chart_path, 'r'))

@aranega aranega left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :) !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants