fix: implement Tuic.Close to release PoolClient resources#2713
Open
beck-8 wants to merge 1 commit into
Open
Conversation
beck-8
marked this pull request as draft
April 15, 2026 11:00
Tuic outbound inherited the no-op Base.Close, so autoCloseProxyAdapter could not cascade cleanup into the PoolClient. Every clientImpl (and its SingleUse quic.Transport) then had to wait for its own closeClient finalizer to run, a multi-cycle GC chain that delays release of the listen/runSendQueue goroutines under rapid create/destroy workloads. Add a public PoolClient.Close that closes every cached clientImpl, and wire it up from Tuic.Close so the Close path is synchronous and does not depend on GC.
beck-8
marked this pull request as ready for review
April 15, 2026 12:48
wwqgtxx
force-pushed
the
Alpha
branch
2 times, most recently
from
April 22, 2026 10:55
5a5e312 to
8d53952
Compare
wwqgtxx
force-pushed
the
Alpha
branch
5 times, most recently
from
May 15, 2026 10:13
61b8d7f to
17bed79
Compare
wwqgtxx
force-pushed
the
Alpha
branch
3 times, most recently
from
June 12, 2026 02:06
f513c49 to
d67572b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.