Skip to content

Release/35.0.0#299

Merged
adonesky1 merged 8 commits into
mainfrom
release/35.0.0
May 18, 2026
Merged

Release/35.0.0#299
adonesky1 merged 8 commits into
mainfrom
release/35.0.0

Conversation

@wenfix
Copy link
Copy Markdown
Contributor

@wenfix wenfix commented May 18, 2026

Release

@metamask/connect-evm -> 1.3.1

Fixed

  • Return method-specific values from intercepted EIP-1193 account requests: eth_requestAccounts now resolves to an accounts array, and eth_coinbase now resolves to the selected account instead of the full accounts array. (#297)

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@wenfix wenfix requested a review from a team as a code owner May 18, 2026 14:38
Comment on lines +12 to +14
### Fixed

- Return method-specific values from intercepted EIP-1193 account requests: `eth_requestAccounts` now resolves to an accounts array, and `eth_coinbase` now resolves to the selected account instead of the full accounts array. ([#297](https://github.com/MetaMask/connect-monorepo/pull/297))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we're considering this a "fix" this would be a patch release according to semver?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines -16 to -19
### Fixed

- Return method-specific values from intercepted EIP-1193 account requests: `eth_requestAccounts` now resolves to an accounts array, and `eth_coinbase` now resolves to the selected account instead of the full accounts array. ([#297](https://github.com/MetaMask/connect-monorepo/pull/297))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait ... was this included in 1.3.0?

Copy link
Copy Markdown
Member

@ffmcgee725 ffmcgee725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validate playground versions are bumped pipeline is failing, we need to either

run

yarn bump-playground-versions

in this branch to bump playground versions

or run

yarn prepare-release

from scratch, which runs yarn create-release-branch -i && yarn bump-playground-versions so we don't have to manually bump the playground versions

jiexi
jiexi previously approved these changes May 18, 2026
Comment thread package.json Outdated
{
"name": "@metamask/connect-monorepo",
"version": "34.0.0",
"version": "34.0.1",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THIS IS WRONG

@adonesky1 adonesky1 merged commit 0aa0395 into main May 18, 2026
21 checks passed
@adonesky1 adonesky1 deleted the release/35.0.0 branch May 18, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants