chore: add missing native asset (erc20:0x0) icons and metadata - #1905
Open
maxime-oe wants to merge 4 commits into
Open
chore: add missing native asset (erc20:0x0) icons and metadata#1905maxime-oe wants to merge 4 commits into
maxime-oe wants to merge 4 commits into
Conversation
Cross-references the SPOT_PRICES_SUPPORT_INFO map in MetaMask Core's codefi-v2.ts against the extension's per-chain native token icons (CHAIN_ID_TOKEN_IMAGE_MAP in shared/constants/network.ts) to backfill 21 chains whose native asset uses the erc20:0x0000...0000 fallback addressing (no clean/official slip44 identifier) and was missing from this repo. Follow-up to the slip44-addressed native assets added in #1898/#1900. - Chains whose native asset is ETH reuse the existing generic ETH icon. - Chains with a distinct native asset (LYX, XDAI, OKB, GHO, FRAX, USDT0, XPL, APE, EDU, XTZ, NXPC, BERA, CHZ, PLUME, XRP) use that asset's icon from metamask-extension's app/images. - Katana (eip155:747474) uses its distinct branded icon even though its native currency symbol is ETH, matching the extension's own CHAIN_ID_TOKEN_IMAGE_MAP choice for that chain. - Fraxtal (eip155:252) uses app/images/frax.svg: the extension's FRAX_NATIVE_TOKEN_IMAGE_URL constant points at a frax-native.svg that no longer exists in its source tree (likely a stale rename), so the current frax.svg was used instead. Left unhandled (no matching native token icon in metamask-extension): Fuse Mainnet (122, only present in the separate network-logo map, not the token-icon map), inEVM Mainnet (2525), ICB Network (73115), Pepe Unchained Mainnet (97741), Forma (984122). No existing files were modified or removed.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…hain icon The erc20:0x0000...0000 fallback in codefi-v2.ts is only meaningful when a chain has no clean/official slip44 id. Chains whose native asset is plain ETH always have one (slip44:60), so address them that way instead, matching every other ETH-native chain in this repo: - eip155:1868 (Soneium), eip155:2741 (Abstract), eip155:43111 (Hemi), eip155:60808 (BOB), eip155:747474 (Katana): moved from erc20:0x0 to slip44:60, reusing the repo's existing generic Ether icon/name/symbol convention instead of the one-off files added previously. - eip155:4326 (MegaETH Mainnet): dropped entirely — it already had a slip44:60 entry from the earlier slip44 batch (#1898), so the erc20:0x0 entry added in the previous commit was a duplicate. Also replaces the Apechain (eip155:33139) native asset icon: the previous icon (app/images/ape.svg from metamask-extension) is a 433x105 wordmark, not a square coin icon. Reused the square, circular ApeCoin logo already established for the ERC20 entry on Ethereum mainnet (eip155:1/erc20:0x4d22...594381), same APE brand.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1a33124. Configure here.
| <rect width="300" height="300" fill="white" transform="translate(30 30)"/> | ||
| </clipPath> | ||
| </defs> | ||
| </svg> |
There was a problem hiding this comment.
Katana native icon replaced incorrectly
Medium Severity
Katana’s distinct branded native icon was replaced with the generic ETH diamond under slip44:60. The PR intends Katana (eip155:747474) to keep its branded native asset artwork even though the currency symbol is ETH, matching the extension’s CHAIN_ID_TOKEN_IMAGE_MAP choice. Users on Katana will now see the wrong native token icon.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 1a33124. Configure here.
Contributor
Author
There was a problem hiding this comment.
I think it's supposed to be ETH
The icon reused for eip155:33139's erc20:0x0 entry (borrowed from the Ethereum mainnet APE ERC-20) was an ape-skull mark, not the ApeChain brand's current gorilla-silhouette icon used elsewhere for this asset (matches the icon now shipped in metamask-extension/metamask-mobile).
Rebuild from ApeChain's own partner launch template (gorilla mark + brand blue), square background, matching the same icon just applied in metamask-extension.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cross-references the SPOT_PRICES_SUPPORT_INFO map in MetaMask Core's codefi-v2.ts against the extension's per-chain native token icons (CHAIN_ID_TOKEN_IMAGE_MAP in shared/constants/network.ts) to backfill 21 chains whose native asset uses the erc20:0x0000...0000 fallback addressing (no clean/official slip44 identifier) and was missing from this repo.
Follow-up to the slip44-addressed native assets added in #1898/#1900.
Left unhandled (no matching native token icon in metamask-extension): Fuse Mainnet (122, only present in the separate network-logo map, not the token-icon map), inEVM Mainnet (2525), ICB Network (73115), Pepe Unchained Mainnet (97741), Forma (984122).
No existing files were modified or removed.
Note
Low Risk
Additive-only static icon and metadata files with no logic, auth, or data-handling changes.
Overview
Backfills 21 missing native-asset icons and metadata for chains that address their native token via
erc20:0x000…000(orslip44:60for ETH-native chains), following earlier slip44 native-asset additions.Adds SVG logos plus matching metadata for assets including XDAI, XRP, OKB, GHO, FRAX, APE, EDU, LYX, XTZ, NXPC, BERA, CHZ, XPL, USDT0, PLUME, and ETH on several L2s. ETH-native chains reuse the generic ETH icon; Katana keeps its branded icon despite an ETH symbol. No existing files are changed.
Reviewed by Cursor Bugbot for commit bfd313e. Bugbot is set up for automated code reviews on this repo. Configure here.