Resolve ambiguous MiniProfilerExtensions reference#698
Open
leno23 wants to merge 1 commit into
Open
Conversation
MiniProfiler.Shared and MiniProfiler.AspNetCore both defined a static MiniProfilerExtensions class in StackExchange.Profiling, causing CS0433 when callers used the fully qualified type name (for example in source generators). Rename the ASP.NET Core extension holder to MiniProfilerAspNetCoreExtensions. Extension method call sites are unchanged. Fixes MiniProfiler#683 Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MiniProfiler.SharedandMiniProfiler.AspNetCoreboth declared aMiniProfilerExtensionstype inStackExchange.Profiling.global::StackExchange.Profiling.MiniProfilerExtensions(for example from source generators) fails with CS0433 when both assemblies are referenced, such as viaMiniProfiler.AspNetCore.Mvc.MiniProfilerAspNetCoreExtensions. Extension method usage such asprofiler.RenderIncludes(...)is unchanged.Fixes #683
Test plan
MiniProfiler.AspNetCore.Mvcreferencedglobal::StackExchange.Profiling.MiniProfilerExtensions.Step(...)resolves without CS0433RenderIncludesextension method calls still compile