fix: reference Dapper instead of Dapper.StrongName in providers (#693)#701
Open
leno23 wants to merge 2 commits into
Open
fix: reference Dapper instead of Dapper.StrongName in providers (#693)#701leno23 wants to merge 2 commits into
leno23 wants to merge 2 commits into
Conversation
Switch provider and sample projects to the unsigned Dapper package to avoid CS0433 type conflicts when consumers also reference Dapper and packages such as Dapper.SqlBuilder. Fixes MiniProfiler#693 Co-authored-by: Cursor <cursoragent@cursor.com>
Keep Dapper.StrongName on net472 so signed provider assemblies load correctly, while netstandard2.0/net8.0 use unsigned Dapper to avoid CS0433 when consumers reference Dapper.SqlBuilder. Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
AppVeyor failure on Pushed |
Author
|
CI green on |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dapper.StrongNamewithDapperin all SQL provider projects and sample appsCS0433when consumers reference the unsignedDapperpackage (e.g. alongsideDapper.SqlBuilder)Fixes #693
Test plan
MiniProfiler.Providers.SqlServerandDapperno longer hitsSqlMappertype ambiguity