Enchantments fixes - #7599
Open
cyberascetic wants to merge 6 commits into
Open
Conversation
…Vanderlin into Enchantments-fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Fixes life eternal enchantment from state where it heals you ONLY if your brain is damaged, to the state where you get slight increase of healing power with every item enchanted with this enchantment.
Binding runes now work as intended (before that even enchanter couldn't to take off enchanted item). Closes #7196
And finally gives adequate output to STR potion brewing, which is 25, as every other stat potion have.
Why It's Good For The Game
Changelog
🆑Jmih
fix: Life eternal enchantment works properly now, and healing scales with each item that have this enchantment
fix: Enchanter can take off item with "binding runes" now
fix: STR potion brewing gives 25 units instead of 5, like any other buff potion
/:cl:
Pre-Merge Checklist