Skip to content

Jazz Club Associate Role - #150

Open
ChristopherDAdams wants to merge 9 commits into
Monkestation:masterfrom
ChristopherDAdams:JazzClubAssociate
Open

Jazz Club Associate Role#150
ChristopherDAdams wants to merge 9 commits into
Monkestation:masterfrom
ChristopherDAdams:JazzClubAssociate

Conversation

@ChristopherDAdams

@ChristopherDAdams ChristopherDAdams commented Aug 16, 2026

Copy link
Copy Markdown

About The Pull Request

Brought over from from The-Final-Nights/The-Final-Nights-Rebase#223.

Small map edits for the Jazz Club on both maps. Adding curtains and spawn points.
Created a new Jazz Club Associate Role, mirroring the Strip Club's generalized role.
Sprited a new neon sign, "Crown Blues."
Sprited Blue Curtains.
Garage with Limo.

Specifically, my goals were to make it fancy, of course, but also to make it have multiple levels of engagement.

The intent is that the Ventrue act as "managers/owners/Patrons" in mortal eyes, with the Primogen being the main manager of the building and making ventrue not required to run the building at a basic level. Any player can take the new jazz associate role and would be expected to respect their chain of command, but have the authority of an employee. Most of the building is unlocked at round start. Jazz Club Associates have limited keys to the building, "kinda businessy keys" to show they're working there. Ventrue with can also lock down the building if they wish, but it should be justified. If it seems pompous and busy, that's the point! I assure you Ventrue can afford it, and they're clueless enough to think it's not too much.

Why It's Good For The Game

Ventrue Haven is Fancy Fancy now. This is NOT only for Ventrue Enjoyment but for any and all characters who have a more... refined pallet.

Last Tested Screen-Rec:

(coming)

Screenshots:

Jazz Club Associate:
image
image
Screenshot 2026-08-15 201607

Map Edits are just curtains, a sign, and the spawn locations.

San Fang:
image
image

Oakland:
image
Screenshot 2026-08-15 234122
image

Changelog

🆑
image: added Crown Blue Sign.dm, blue curtains, jazz club associate spawn icon to landmarks.dm
map: Added them to Oak and SanFran
code: Added Jazz Club Drop Down Associate Role!
/:cl:

@ChristopherDAdams ChristopherDAdams changed the title (Do Not Merge) Jazz Club Associate Role (Ready for TM) Jazz Club Associate Role Aug 16, 2026
@ChristopherDAdams ChristopherDAdams changed the title (Ready for TM) Jazz Club Associate Role Jazz Club Associate Role Aug 16, 2026
Comment on lines 130 to +134
#define JOB_DISPLAY_ORDER_STREETJAN 1
#define JOB_DISPLAY_ORDER_STRIP 2
#define JOB_DISPLAY_ORDER_TAXI 3
#define JOB_DISPLAY_ORDER_PRIEST 4
#define JOB_DISPLAY_ORDER_JAZZ 3
#define JOB_DISPLAY_ORDER_TAXI 4
#define JOB_DISPLAY_ORDER_PRIEST 5

@chazzyjazzy chazzyjazzy Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSYK, these are clearly categorized now so as to be localized into their own little boxes. for example above this block is 'clinics director 1' and 'doctor 2', which means that in the 'clinic' department selectable box, clinci director will appear first, doctor second. do with that what u will. also not modularized.

Comment on lines +198 to +200
#define DEPARTMENT_BITFLAG_JAZZ_CLUB (1<<7)
#define DEPARTMENT_JAZZ_CLUB "Jazz Club"
#define DEPARTMENT_BITFLAG_SUPPLY (1<<8)

@chazzyjazzy chazzyjazzy Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why? why not just move it to the bottom in a //CRIMSON EDIT ADD (btw demodularized. why not bring it to darkpack?)

"CLINIC" = DEPARTMENT_BITFLAG_CLINIC,
"ANARCH" = DEPARTMENT_BITFLAG_ANARCH,
"STRIP_CLUB" = DEPARTMENT_BITFLAG_STRIP_CLUB,
"JAZZ_CLUB" = DEPARTMENT_BITFLAG_JAZZ_CLUB,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crimson edit add.

#define SUPERVISOR_BARON "the Baron"
#define SUPERVISOR_CLINIC_DIRECTOR "the Clinic Director"
#define SUPERVISOR_CLUB_DIRECTOR PRIMARY_NIGHTCLUB_COMPANY + " Night Club Owner"
#define SUPERVISOR_JAZZ_CLUB_DIRECTOR PRIMARY_JAZZCLUB_COMPANY + " Jazz Club Owner"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crimson edit add.

#define EXP_TYPE_MANOR "Tzimisce Manor"
#define EXP_TYPE_CHURCH "Church"
#define EXP_TYPE_CLUB "Strip Club"
#define EXP_TYPE_JAZZ_CLUB "Jazz Club"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crazy add but alright, we don't really use xp tracking but it could be useful. crimson edit add.


GLOBAL_LIST_EMPTY(millenium_tower_network)
GLOBAL_LIST_EMPTY(lasombra_network)
GLOBAL_LIST_EMPTY(ventrue_network)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crimson edit add

Comment on lines +22 to +30
#define VENTRUE_NETWORK 3
#define TREMERE_NETWORK 4
#define GIOVANNI_NETWORK 5
#define TZMISCE_NETWORK 6
#define ANARCH_NETWORK 7
#define SUPPLY_NETWORK 8
#define VAMPIRE_LEADER_NETWORK 9
#define ENDRON_NETWORK 10
#define SOCIETY_OF_LEOPOLD_NETWORK 11

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again just inserting into the middle of the list for no reason, why not at the end with the max + 1?

GLOBAL_LIST_INIT(contact_networks, alist(
MILLENIUM_TOWER_NETWORK = GLOB.millenium_tower_network,
LASOMBRA_NETWORK = GLOB.lasombra_network,
VENTRUE_NETWORK = GLOB.ventrue_network,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crimson edit add

Comment on lines +309 to +315
/obj/item/vamp/keys/jazz
name = "kinda businessy keys"
accesslocks = list(
LOCKACCESS_JAZZ_CLUB
)
color = "#e0dca5"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/obj/item/vamp/keys/jazz
name = "kinda businessy keys"
accesslocks = list(
LOCKACCESS_JAZZ_CLUB
)
color = "#e0dca5"
// CRIMSON EDIT ADD START - Jazz Club Associate
/obj/item/vamp/keys/jazz
name = "kinda businessy keys"
accesslocks = list(
LOCKACCESS_JAZZ_CLUB
)
color = "#e0dca5"
// CRIMSON EDIT ADD END - Jazz Club Associate


display_order = JOB_DISPLAY_ORDER_VENTRUE
departments_list = list(
/datum/job_department/jazz_club,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crimson edit add

Comment on lines +48 to +55
/datum/job_department/jazz_club
department_name = DEPARTMENT_JAZZ_CLUB
department_bitflags = DEPARTMENT_BITFLAG_JAZZ_CLUB
department_head = /datum/job/vampire/primogen_ventrue
department_experience_type = EXP_TYPE_JAZZ_CLUB
display_order = 5
ui_color = "#7372ac"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/datum/job_department/jazz_club
department_name = DEPARTMENT_JAZZ_CLUB
department_bitflags = DEPARTMENT_BITFLAG_JAZZ_CLUB
department_head = /datum/job/vampire/primogen_ventrue
department_experience_type = EXP_TYPE_JAZZ_CLUB
display_order = 5
ui_color = "#7372ac"
// CRIMSON EDIT ADD START - Jazz Club Associate
/datum/job_department/jazz_club
department_name = DEPARTMENT_JAZZ_CLUB
department_bitflags = DEPARTMENT_BITFLAG_JAZZ_CLUB
department_head = /datum/job/vampire/primogen_ventrue
department_experience_type = EXP_TYPE_JAZZ_CLUB
display_order = 5
ui_color = "#7372ac"
// CRIMSON EDIT ADD END - Jazz Club Associate

Comment on lines 62 to +71
@@ -60,23 +68,23 @@
department_bitflags = DEPARTMENT_BITFLAG_GIOVANNI
department_head = /datum/job/vampire/capo
department_experience_type = EXP_TYPE_GIOVANNI
display_order = 6
display_order = 7

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im gonna stop reviewing here. this should be on darkpack.

@Marshmellow105 Marshmellow105 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your map is going to have conflicts with the merged deshittification pr, take care not to overwrite those changes

also this half wall seems to have a low wallpaper decal inside a wall
image

@github-actions

Copy link
Copy Markdown

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~7 days. Please address any outstanding review items and ensure your PR is finished - if both are true, and you have auto-staled anyway, you need to actively ask maintainers (by pinging them in the /tg/station Discord) to (re)review or merge your PR. If no maintainer responds to your request, you may wish to close this PR yourself while you seek maintainer comment, as you will later be able to reopen the PR yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants