Great Roles Update

[SixplyDev]

About The Pull Request

Adjusted role locks, slots, etc. Added a few new roles

Why It's Good For The Game

Additionally, this does some minor changes to roles. Changes are listed below:
Pentex Internal Affairs Agent: Removed Ronin, BSD only now. BSD would likely kill a Ronin in this position, other Pentex jobs untouched.
Emissary/Harpy: Removed gargoyle, nosferatu, & samedi due to them being masq breaching clans and these being the public faces of their respective factions.
Primogens: Min generation made 10 & minimal immortal age made 100. Exception is malk which is 50.
Clinic Director: Removed kindred to make human/kinfolk/ghoul only. Impartial role, should be free of supernatural influence.
Doctor: Permitted garou & corax to also be doctors at the clinic.
Sheriff/Harpy/Seneschal: Min generation lowered from 12 to 11.
Novice: Permitted kinfolk to be an inquisitorial novice with a cap of 1.
Priest: Permitted lasombra to be a priest, seeing as their primogen has a haven in the church.
Pentex Exec: Permitted humans, ghouls, and kinfolk to be an executive. Seemed odd they could be a branch lead but not an executive.
Pentex Sec Chief: Permitted humans, ghouls, and kinfolk to be the security chief. Time will tell if this was a good change or not.
FBI Investigator: Received several new flavor titles, yippee!!
Dealer: Minimum masquerade raised to 3 because it requires some discretion. Lowered to 1 as well, and permitted any role to be a dealer rather than capping it to 1 human across 2 dealers. Removed the human cap, obviously.
Police Officer: Lowered ghoul & kinfolk slots from 2 each to 1 each.
Police Sergeant: Removed the ability to be played by ghouls
Harpy: Slots lowered from 3 to 1

I may have forgotten one or two changes, but this should be pretty much all the changes for anyone interested!

Changelog

🆑 ShirouAjisai
add: Added new flavor titles for FBI Investigator.
add: Tweaked some splatlocks on roles such as Pentex IAA, Clinic Director, Pentex Sec Chief, Inquisitor Novice, etc.
del: Removed some splatlocks on roles such as doctor, exec, & dealer.
/:cl:

[chazzyjazzy]

https://github.com/Monkestation/crimson-grid/blob/master/modular_darkpack/readme.md

read #announcements

[SixplyDev]

Lowered harpy slots from 3 to 1, lowered ghoul & kinfolk slots from 2 each to 1 each on police officer, and prevented police sergeants from being ghouls. A max of 4 ghouls & 2 kinfolk was crazy.

[chazzyjazzy]

https://github.com/Monkestation/crimson-grid/blob/master/modular_darkpack/readme.md

[flleeppyy]

You should submit this to upstream instead of here. Otherwise you'll be making a lot of modular comments for a cleanup of code that should be done upstream.
yes i hate modularization as much as the next person but some of these changes would better benefit upstream.

[SixplyDev]

Gonna send it upstream, TM only until it gets merged with upstream etc etc

[SixplyDev]

Ready to be TMed again, code should work as I tested it.

[SixplyDev]

Will work on modularization this weekend after the playtest, shoot me

[chazzyjazzy]

your PR has a testmerge conflict with #107 as both of your PRs are extraordinarily unatomized. don't ever do this again as when it comes time to TM we can only pick one - causing us to, more often than not, regress in features.

what is atomization? it means to make isolated additions in as many PRs as possible. your PRs are not expansion packs or exclusive avenues for you to add additions - they're piecemeal features.

[chazzyjazzy]

because of the fact that this pr has been tacked onto and tacked onto with additional things after my initial review - this needs to be reviewed again

for now - remove the Gargoyle locks, as they are completely lore inaccurate, most gargoyles are either apart of the Camarilla or Sabbat, in fact, few Gargoyles remain loyal to the Tremere

also, consider bringing it to Darkpack as you mentioned you would, if not, needs modularization plz

[SixplyDev]

for now - remove the Gargoyle locks, as they are completely lore inaccurate, most gargoyles are either apart of the Camarilla or Sabbat, in fact, few Gargoyles remain loyal to the Tremere

Garg locks were a temp bandaid until the splatlocks PR was merged & implemented. Issue was with shitter garg players just tanking masq & flying at Z: 6. Will remove the locks.

[halgmor]

As a heads up, this is notably the "Triad PR" too. Add that to the PR description for easy lookup.

[SixplyDev]

Repo got fucked, can't add the necessary changes to this PR on the old repo. New PR is at #171