Repository navigation
Fix crash when modifier Frequency is dragged to zero - #35
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a crash reported when the Frequency property of any modifier is set to zero. The
Modifier.Frequencysetter throwsArgumentOutOfRangeExceptionfor any value less than or equal to zero, and a value of zero would also cause a division by zero when computing_cycleTime = 1f / _frequency.The drag control in the editor was using a minimum of
0.0f, allowing the user to reach the invalid value through normal interaction.Related Issues/Tickets
Changes Made
minargument on the FrequencyDragFloatPropertycall inModifiersView.csfrom0.0fto0.1f, matching the drag step size and ensuring the control cannot produce a value that violates the setter's contract.Checklist