Skip to content

feat: include raw input in ACP permission requests#739

Draft
ktwu01 wants to merge 1 commit into
MoonshotAI:mainfrom
ktwu01:codex/acp-permission-raw-input
Draft

feat: include raw input in ACP permission requests#739
ktwu01 wants to merge 1 commit into
MoonshotAI:mainfrom
ktwu01:codex/acp-permission-raw-input

Conversation

@ktwu01

@ktwu01 ktwu01 commented Jun 14, 2026

Copy link
Copy Markdown

Related Issue

Fixes #734

Problem

ACP permission requests include the tool call summary and options, but the request did not carry the exact tool input. ACP clients that want to inspect the full command or payload had to parse display text or correlate an earlier tool-call update.

What changed

  • Added rawInput to approval requests and populated it from the original tool-call args.
  • Forwarded rawInput onto the ACP requestPermission.toolCall update.
  • Added core, ACP, and SDK type coverage for the new field.
  • Added a minor changeset for the affected packages.

Checklist

  • I have read the CONTRIBUTING document.
  • I have linked a related issue, or explained the problem above.
  • I have added tests that prove my feature works.
  • Ran gen-changesets skill, or this PR needs no changeset.
  • Ran gen-docs skill, or this PR needs no doc update.

Validation:

  • pnpm --filter @moonshot-ai/acp-adapter exec vitest run test/approval.test.ts
  • pnpm --filter @moonshot-ai/agent-core exec vitest run test/agent/permission.test.ts test/agent/turn.test.ts test/agent/basic.test.ts test/agent/config.test.ts
  • pnpm --filter @moonshot-ai/kimi-code-sdk exec vitest run test/session-event-types.test.ts
  • pnpm --filter @moonshot-ai/agent-core typecheck
  • pnpm --filter @moonshot-ai/acp-adapter typecheck
  • pnpm --filter @moonshot-ai/kimi-code-sdk typecheck
  • pnpm --filter @moonshot-ai/kimi-code typecheck
  • pnpm exec oxlint --type-aware packages/acp-adapter/src/approval.ts packages/acp-adapter/test/approval.test.ts packages/agent-core/src/agent/permission/index.ts packages/agent-core/src/agent/permission/types.ts packages/agent-core/src/rpc/sdk-api.ts packages/agent-core/test/agent/basic.test.ts packages/agent-core/test/agent/config.test.ts packages/agent-core/test/agent/permission.test.ts packages/agent-core/test/agent/turn.test.ts packages/node-sdk/test/session-event-types.test.ts

@changeset-bot

changeset-bot Bot commented Jun 14, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d6c04af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@moonshot-ai/agent-core Minor
@moonshot-ai/acp-adapter Minor
@moonshot-ai/kimi-code Minor
@moonshot-ai/migration-legacy Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include rawInput in ACP execute tool permission request

1 participant