feat: include raw input in ACP permission requests#739
Draft
ktwu01 wants to merge 1 commit into
Draft
Conversation
🦋 Changeset detectedLatest commit: d6c04af The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #734
Problem
ACP permission requests include the tool call summary and options, but the request did not carry the exact tool input. ACP clients that want to inspect the full command or payload had to parse display text or correlate an earlier tool-call update.
What changed
rawInputto approval requests and populated it from the original tool-call args.rawInputonto the ACPrequestPermission.toolCallupdate.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.Validation:
pnpm --filter @moonshot-ai/acp-adapter exec vitest run test/approval.test.tspnpm --filter @moonshot-ai/agent-core exec vitest run test/agent/permission.test.ts test/agent/turn.test.ts test/agent/basic.test.ts test/agent/config.test.tspnpm --filter @moonshot-ai/kimi-code-sdk exec vitest run test/session-event-types.test.tspnpm --filter @moonshot-ai/agent-core typecheckpnpm --filter @moonshot-ai/acp-adapter typecheckpnpm --filter @moonshot-ai/kimi-code-sdk typecheckpnpm --filter @moonshot-ai/kimi-code typecheckpnpm exec oxlint --type-aware packages/acp-adapter/src/approval.ts packages/acp-adapter/test/approval.test.ts packages/agent-core/src/agent/permission/index.ts packages/agent-core/src/agent/permission/types.ts packages/agent-core/src/rpc/sdk-api.ts packages/agent-core/test/agent/basic.test.ts packages/agent-core/test/agent/config.test.ts packages/agent-core/test/agent/permission.test.ts packages/agent-core/test/agent/turn.test.ts packages/node-sdk/test/session-event-types.test.ts