fix: set Kimi temperature when thinking is disabled#740
Draft
ktwu01 wants to merge 1 commit into
Draft
Conversation
🦋 Changeset detectedLatest commit: 4102ac2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #686
Problem
When Kimi thinking is disabled, the provider sends
thinking: { type: "disabled" }but does not set a temperature unless one was provided through generation kwargs. The managed Kimi coding model rejects thinking-disabled requests unless the request usestemperature: 0.6.What changed
temperature: 0.6on Kimi requests whenthinking.typeisdisabledand no explicit temperature is already present.@moonshot-ai/kosongand the CLI bundle.Validation
pnpm --filter @moonshot-ai/kosong exec vitest run test/kimi.test.tspnpm --filter @moonshot-ai/kosong typecheckpnpm --filter @moonshot-ai/kimi-code typecheckpnpm exec oxlint --type-aware packages/kosong/src/providers/kimi.ts packages/kosong/test/kimi.test.tsChecklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.