fix: apply output cap during compaction#742
Closed
ktwu01 wants to merge 1 commit into
Closed
Conversation
🦋 Changeset detectedLatest commit: a7b66d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
|
Thanks for contributing. This PR appears to be part of a batch generated by AI scanning the issue list, and we are not accepting this kind of bulk PR, so it is being closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #476
Problem
Normal model requests pass the configured model
maxOutputSizeinto completion budget resolution, but full compaction requests only passed the reserved-context fallback. For models with a very large context window and a smaller output cap, compaction could therefore send a completion cap based on context size rather than the model output limit.What changed
this.agent.config.maxOutputSizeinto full compaction's completion budget resolution.@moonshot-ai/agent-coreand the CLI bundle.Validation
pnpm --filter @moonshot-ai/agent-core exec vitest run test/agent/compaction/full.test.tspnpm --filter @moonshot-ai/agent-core typecheckpnpm --filter @moonshot-ai/kimi-code typecheckpnpm exec oxlint --type-aware packages/agent-core/src/agent/compaction/full.ts packages/agent-core/test/agent/compaction/full.test.tsChecklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.