fix: preserve custom registry output caps#757
Closed
ktwu01 wants to merge 1 commit into
Closed
Conversation
🦋 Changeset detectedLatest commit: 83bf7af The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
|
Thanks for contributing. This PR appears to be part of a batch generated by AI scanning the issue list, and we are not accepting this kind of bulk PR, so it is being closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolve #509
Problem
Custom registry imports preserve model context limits but dropped provider-declared output limits. For OpenAI-compatible models with very large context windows, the completion budget could then use the context window as the request output cap, which can make providers reject the request with an invalid
max_tokenserror.What changed
Custom registry model aliases now preserve valid
limit.outputvalues asmaxOutputSize. Refresh coverage verifies output-limit metadata is carried forward while user-defined aliases remain untouched, and the OAuth unit test covers alias generation from rich registry metadata.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.Validation:
pnpm vitest run packages/oauth/test/custom-registry.test.ts apps/kimi-code/test/tui/utils/refresh-providers.test.ts apps/kimi-code/test/cli/provider.test.tspnpm --filter @moonshot-ai/kimi-code-oauth typecheckpnpm --filter @moonshot-ai/kimi-code typecheckpnpm run lint