move to use max instead of if else in length, use list comprehension to simplify for loops - #95
Open
galrock wants to merge 6 commits into
Open
move to use max instead of if else in length, use list comprehension to simplify for loops #95galrock wants to merge 6 commits into
galrock wants to merge 6 commits into
Conversation
MrBr-github
reviewed
Apr 4, 2023
| self.output.append(data) | ||
|
|
||
| def __add__(self,data): | ||
| self.output.append(data) |
MrBr-github
approved these changes
Apr 4, 2023
MrBr-github
reviewed
Apr 4, 2023
|
|
||
| # based on https://docs.mellanox.com/pages/viewpage.action?pageId=43714202#LinkLayerDiscoveryProtocol(LLDP)-lldptimer | ||
| lldp_capture_timeout = 35 # seconds. Based on default 30s value in Mellanox Onyx OS | ||
|
|
Owner
There was a problem hiding this comment.
I disagree with this section, please remove
MrBr-github
reviewed
Apr 4, 2023
| port_count = 1 | ||
|
|
||
| while True: | ||
| while True and port_count < len(bdf_dev.port_list): |
Owner
There was a problem hiding this comment.
The introduced change has different functionality from existing code
galrock
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.