Skip to content

Fix: NHS App pop ups #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Namitha-Prabhu merged 2 commits into from
Apr 28, 2026
Merged

Fix: NHS App pop ups #104

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12be3cf
fix
Namitha-Prabhu Apr 28, 2026
5ddbf07
Merge branch 'main' into feature/App-Flow-fix
Namitha-Prabhu Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions helpers/ui/nhs_app_journey.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from pathlib import Path
from time import sleep
from install_playwright import install
from playwright.sync_api import expect, sync_playwright
from playwright.sync_api import expect, sync_playwright, TimeoutError as PlaywrightTimeoutError
import re
import os
from helpers.logger import get_logger
Expand Down Expand Up @@ -65,15 +65,23 @@ def nhs_app_login_and_view_message(ods_name=None, personalisation=None):
page.get_by_label("Security code", exact=True).fill(os.environ['NHS_APP_OTP'])
page.get_by_role("button", name="Continue").click()
logger.info("Entered OTP")

expect(page.get_by_role("heading", name="Trust this device and log in faster next time", exact=True)).to_be_visible()
page.locator('input[name="remember"][value="yes"]').check()
page.get_by_role("button", name="Continue").click()


try:
page.wait_for_url("**/trust-device**", timeout=10000)
except PlaywrightTimeoutError:
logger.info(f"Trust-device page not shown; continuing. Current URL: {page.url}")

if "/trust-device" in page.url:
page.locator('input[name="remember"][value="yes"]').check()
page.get_by_role("button", name="Continue").click()
logger.info("Trusted device option selected and continued")



page.locator(".loading-spinner").wait_for(state="hidden")
page.wait_for_url('**/patient/**')

# page.wait_for_url('**/patient/**')
page.wait_for_load_state("networkidle")

if(page.url.endswith("/patient/whats-new")):
page.get_by_role("button", name="Continue").click()

Expand Down