fix(nrl-k8s): remove SA impersonation from dev pod RBAC check#2655
Open
terrykong wants to merge 2 commits into
Open
fix(nrl-k8s): remove SA impersonation from dev pod RBAC check#2655terrykong wants to merge 2 commits into
terrykong wants to merge 2 commits into
Conversation
The preflight RBAC check used kubectl auth can-i --as=system:serviceaccount:... which requires the impersonate verb on serviceaccounts. Most users on EKS with SSO-based roles lack this permission, causing nrl-k8s dev connect to fail even when the user has full edit access in the namespace. Check the current user's own permissions instead. Signed-off-by: Terry Kong <terryk@nvidia.com>
jthomson04
approved these changes
Jun 1, 2026
terrykong
added
the
CI:Lfast
Collaborator
Author
|
/ok to test 6664ec1 |
Collaborator
Author
|
/ok to test 20633ab |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nrl-k8s dev connectRBAC preflight check usedkubectl auth can-i --as=system:serviceaccount:...which requires theimpersonateverb on serviceaccounts--asflag so the check tests the current user's own permissions insteadTest plan
kubectl auth can-i get pods -n defaultreturnsyes(previously failed with impersonation)nrl-k8s dev connectpasses the RBAC check and creates the dev pod successfullyValidation
Install from this branch:
uv tool install --reinstall "nrl-k8s @ git+https://github.com/NVIDIA-NeMo/RL.git@tk/fix-dev-rbac-check#subdirectory=infra/nrl_k8s"Then run:
Previously this failed with:
The root cause was
kubectl auth can-i --as=system:serviceaccount:default:defaultreturning aForbiddenerror (cannot impersonate serviceaccounts), which the CLI misinterpreted as missing RBAC.After the fix, the RBAC check passes and the dev pod creates and connects successfully.
Generated with Claude Code