Skip to content

feat: Enable tqdm configuration for vllm generation#2677

Open
louisfaury wants to merge 4 commits into
NVIDIA-NeMo:mainfrom
louisfaury:lf/disable-tqdm-vllm
Open

feat: Enable tqdm configuration for vllm generation#2677
louisfaury wants to merge 4 commits into
NVIDIA-NeMo:mainfrom
louisfaury:lf/disable-tqdm-vllm

Conversation

@louisfaury

@louisfaury louisfaury commented Jun 3, 2026

Copy link
Copy Markdown

What does this PR do ?

This PR adds a config field to disable the progress bars that vLLM displays per-default when generating.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Enable tqdm configuration for vllm generation
34c8527 
Signed-off-by: Louis Faury <louis.faury@helsing.ai>
@louisfaury louisfaury requested a review from a team as a code owner June 3, 2026 11:49
@copy-pr-bot

copy-pr-bot Bot commented Jun 3, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@louisfaury louisfaury changed the title Enable tqdm configuration for vllm generation feat: Enable tqdm configuration for vllm generation Jun 3, 2026
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the waiting-on-maintainers Waiting on maintainers to respond label Jun 5, 2026
yuki-97
yuki-97 reviewed Jun 6, 2026
View reviewed changes

@yuki-97 yuki-97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@louisfaury thanks for adding this, left one minor comment.

Comment thread nemo_rl/models/generation/vllm/config.py
@svcnvidia-nemo-ci svcnvidia-nemo-ci added waiting-on-customer Waiting on the original author to respond and removed waiting-on-maintainers Waiting on maintainers to respond labels Jun 6, 2026
@louisfaury louisfaury requested a review from a team as a code owner June 7, 2026 21:23
PR feedback
b13165d 
Signed-off-by: Louis Faury <louis.faury@helsing.ai>
@louisfaury louisfaury force-pushed the lf/disable-tqdm-vllm branch from e987407 to b13165d Compare June 7, 2026 21:27
@louisfaury louisfaury requested a review from yuki-97 June 7, 2026 21:30
@svcnvidia-nemo-ci svcnvidia-nemo-ci removed the waiting-on-customer Waiting on the original author to respond label Jun 8, 2026
@yuki-97 yuki-97 added the CI:Lfast Runs a fast test suite and re-use nightly `main` container (but sync dependencies to PRs version) label Jun 8, 2026
@yuki-97

yuki-97 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

/ok to test b13165d

@yuki-97

yuki-97 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

/ok to test 7f10c27

@yuki-97 yuki-97 enabled auto-merge (squash) June 8, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuki-97 yuki-97 yuki-97 approved these changes

Assignees

No one assigned

Labels

CI:Lfast Runs a fast test suite and re-use nightly `main` container (but sync dependencies to PRs version) community-request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@louisfaury @yuki-97 @svcnvidia-nemo-ci