Skip to content

Fix complex GMRES inner products #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2002WYT wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix complex GMRES inner products #378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/blas.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,7 +650,7 @@ typename Vector::value_type dotc(const Vector &a, const Vector &b, int offset, i
const value_type *a_raw = a.raw() + a_first;
const value_type *b_raw = b.raw() + b_first;
value_type result;
Cublas::dot(size, a_raw, 1, b_raw, 1, &result);
Cublas::dotc(size, a_raw, 1, b_raw, 1, &result);
cudaCheckError();
return result;
}
Expand Down Expand Up @@ -684,7 +684,7 @@ typename Vector::value_type dotc(const Vector &a, const Vector &b, int offseta,
const value_type *a_raw = a.raw() + a_first;
const value_type *b_raw = b.raw() + b_first;
value_type result;
Cublas::dot(size, a_raw, 1, b_raw, 1, &result);
Cublas::dotc(size, a_raw, 1, b_raw, 1, &result);
cudaCheckError();
return result;
}
Expand Down
2 changes: 1 addition & 1 deletion src/solvers/gmres_solver.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ GMRES_Solver<T_Config>::solve_iteration( VVector &b, VVector &x, bool xIsZero )
for ( int k = 0; k <= i; ++k )
{
// H(k,i) = <V(i+1),V(k)> //
m_H(k, i) = dot(A, m_V_vectors[i + 1], m_V_vectors[k]);
m_H(k, i) = dot(A, m_V_vectors[k], m_V_vectors[i + 1]);
// V(i+1) -= H(k, i) * V(k) //
axpy( m_V_vectors[k], m_V_vectors[i + 1], types::util<ValueTypeB>::invert(m_H(k, i)), offset, size );
}
Expand Down