Skip to content

Add Secret scanning workflow - #6390

Draft
JanuszL wants to merge 3 commits into
NVIDIA:mainfrom
JanuszL:secret_scaner_workflow
Draft

Add Secret scanning workflow#6390
JanuszL wants to merge 3 commits into
NVIDIA:mainfrom
JanuszL:secret_scaner_workflow

Conversation

@JanuszL

@JanuszL JanuszL commented Jun 8, 2026

Copy link
Copy Markdown
Contributor
  • adds NVIDIA/security-workflows/.github/workflows/secret-scan-trufflehog.yml workflow

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

  • adds NVIDIA/security-workflows/.github/workflows/secret-scan-trufflehog.yml workflow

Additional information:

Affected modules and functionalities:

  • workflows

Key points relevant for the review:

  • NA

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@greptile-apps

greptile-apps Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR introduces a GitHub Actions workflow that runs TruffleHog secret scanning on pull requests targeting main, delegating to the NVIDIA/security-workflows composite action pinned at a full commit SHA.

  • The fetch-depth: 0 input is passed to the composite action but is not listed among the documented optional overrides (runs-on, extra-args, fail-on-findings); if the action does not declare it, it will be silently ignored and the scan may only have access to a shallow clone.
  • Only pull_request is wired up as a trigger — direct pushes to main and periodic full-history scans (which catch newly-added TruffleHog detectors against historical commits) are not covered, unlike the parallel codeql.yml which uses both push and schedule.

Confidence Score: 3/5

Safe to merge as a no-op for existing code, but the scanning workflow itself may not work as intended due to the fetch-depth concern and missing triggers.

The workflow is the only changed file. The action is correctly pinned to a full SHA. However, fetch-depth: 0 is passed as an input to the composite action but is not listed among its documented overrides — if the action does not declare this input it will be silently ignored and TruffleHog will run against a shallow clone, reducing the scan's effectiveness. Additionally, no push or schedule triggers are configured, leaving direct commits to main and periodic rescans of historical commits uncovered.

.github/workflows/security.yml — confirm whether fetch-depth is a declared input of the secret-scan-trufflehog composite action, and consider adding push and schedule triggers.

Important Files Changed

Filename Overview
.github/workflows/security.yml New TruffleHog secret-scan workflow; action is properly pinned to a full commit SHA, but fetch-depth may be silently ignored by the composite action, and only pull_request triggers are configured (missing push and schedule).

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR opened/updated targeting main] --> B{pull_request trigger}
    B --> C[Job: security runs-on: ubuntu-latest]
    C --> D[uses: NVIDIA/security-workflows secret-scan-trufflehog @ pinned SHA]
    D --> E{fetch-depth: 0 recognized input?}
    E -->|Yes| F[Full history checkout TruffleHog scans all commits]
    E -->|No - silently ignored| G[Shallow checkout TruffleHog scans PR diff only]
    F --> H{Secrets found?}
    G --> H
    H -->|Yes| I[Job fails]
    H -->|No| J[Job passes]
Loading

Fix All in Claude Code

Reviews (1): Last reviewed commit: "Add Secret scaning workflow" | Re-trigger Greptile

Comment thread .github/workflows/security.yml Outdated
Comment thread .github/workflows/security.yml
Comment thread .github/workflows/security.yml
@JanuszL
JanuszL marked this pull request as draft June 8, 2026 18:41
@mzient mzient changed the title Add Secret scaning workflow Add Secret scanning workflow Jun 9, 2026
@JanuszL
JanuszL force-pushed the secret_scaner_workflow branch from 611a0f0 to 392634f Compare July 24, 2026 13:42
- adds NVIDIA/security-workflows/.github/workflows/secret-scan-trufflehog.yml
  workflow

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
JanuszL force-pushed the secret_scaner_workflow branch from 392634f to e5f7daa Compare July 24, 2026 13:44
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
JanuszL force-pushed the secret_scaner_workflow branch from 42b59af to 8316dd6 Compare July 24, 2026 13:55
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant