Use python-build for package artifacts - #6433
Conversation
Replace direct setup.py invocations with python -m build for DALI wheels and\nsource distributions. Preserve existing wheel configuration through backend\nconfig settings and avoid isolated dependency resolution in container builds. Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
!build |
|
| Filename | Overview |
|---|---|
| docker/Dockerfile_dali_tf | Installs setuptools>=70 but omits the new build package dependency required by make_dali_tf_sdist.sh — TF plugin sdist build will fail. |
| docker/build_helper.sh | Replaces python setup.py bdist_wheel with python -m build --wheel --no-isolation; options correctly split between --global-option and --build-option after previous review fix. |
| docker/Dockerfile.make_sdist_plugins | Correctly adds the build package alongside existing setuptools>=70 and scikit-build to support python -m build in the video plugin path. |
| dali_tf_plugin/make_dali_tf_sdist.sh | Switches TF plugin sdist creation from python setup.py sdist to python -m build --sdist --no-isolation; correct invocation, but depends on build being installed in the container image. |
| plugins/setup.py.in | Adds egg_info to the skip-list alongside sdist so the DALI import/version guard does not run when build calls setup.py egg_info during PEP 517 metadata discovery. |
| plugins/video/CMakeLists.txt | Replaces setup.py sdist with python -m build --sdist --no-isolation in the CMake post-build command for the video plugin. |
Reviews (4): Last reviewed commit: "Allow plugin sdist metadata without DALI" | Re-trigger Greptile
|
CI MESSAGE: [59275705]: BUILD STARTED |
Pass bdist_wheel options as backend build options and update the stale build comment. Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
!build |
|
CI MESSAGE: [59277870]: BUILD STARTED |
|
CI MESSAGE: [59277870]: BUILD FAILED |
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
!build |
|
CI MESSAGE: [59317998]: BUILD STARTED |
|
CI MESSAGE: [59317998]: BUILD FAILED |
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
!build |
|
CI MESSAGE: [59363946]: BUILD STARTED |
|
CI MESSAGE: [59363946]: BUILD PASSED |
Category:
Other
Description:
Modernize package artifact creation by replacing direct
setup.pyinvocationswith
python -m build. The change uses the standard build frontend whileretaining the existing non-isolated container-build behavior.
Additional information:
Affected modules and functionalities:
docker/build_helper.sh.Key points relevant for the review:
--no-isolationpreserves use of dependencies installed in the build image.Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A