bump emerging optimizers to v0.3.0 - #5321
Open
FDecaYed wants to merge 2 commits into
Open
Conversation
svcnvidia-nemo-ci
marked this pull request as draft
June 12, 2026 12:55
Contributor
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
5 tasks
Contributor
Author
|
/ok to test aebd169 |
FDecaYed
force-pushed
the
deyuf/muon_dsv4_main
branch
from
June 12, 2026 12:58
aebd169 to
48232cb
Compare
Contributor
Author
|
/ok to test 48232cb |
Contributor
Author
|
/ok to test 9b57159 |
Signed-off-by: Deyu Fu <deyuf@nvidia.com>
Signed-off-by: Deyu Fu <deyuf@nvidia.com>
FDecaYed
force-pushed
the
deyuf/muon_dsv4_main
branch
from
July 29, 2026 10:25
9b57159 to
72a5a1a
Compare
Contributor
Author
|
/ok to test 72a5a1a |
janEbert
approved these changes
Jul 30, 2026
Contributor
|
Unrelated to this PR, but regarding lines 383–402 (can't select them on GitHub): Can't we use
|
1 task
Phlip79
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mirror of #5320
What does this PR do ?
Issue tracking
For PRs from open-source community contributors:
Linked issue:
Contribution process
Pre-checks
Code review
Feel free to message or comment @NVIDIA/mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.