Add construction-scoped MFSDP fully shard options - #6127
Draft
wujingyue wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Jingyue Wu <jingyuew@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a construction-scoped
fully_shard_options()context manager for experimental MFSDP v2.The symmetric-memory setting previously lived on each
fully_shard()call. This change moves it into a context-local, immutable construction option so callers can configure a group of module sharding operations together.fully_shard()resolves the active option during construction and passes only the boolean throughFsdpModuletoFsdpParameterGroup; no options object is retained and the lazily initialized runtimeFsdpContextis unchanged.The experimental per-call
use_symm_memargument is removed without deprecation. Existing symmetric-memory parity, communication-overlap, zero-CTA, and NCCL symmetric-kernel assertions now usefully_shard_options(use_symmetric_memory=...).Issue tracking
Linked issue:
Contribution process
Pre-checks
Validation
python -m torch.distributed.run --nproc-per-node 2 -m pytest -q tests/unit_tests/distributed/mfsdp_v2/test_fully_shard.py tests/unit_tests/distributed/mfsdp_v2/test_symmetric_memory.pyblack --checkon all changed Python files.ruff checkon all changed Python files.isorton all changed Python files.git diff --check.