fix: refresh TE fused MLP DDP hooks dynamically - #6132
Open
nvegesna-netizen wants to merge 1 commit into
Open
Conversation
Signed-off-by: Nitin Vegesna <nvegesna@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refreshes the Transformer Engine fused MLP's forwarded descendant pre-hooks at
call time so Megatron distributed-data-parallel parameter-gather hooks continue
to run when DDP enables or replaces them after the fused implementation is
constructed.
TEFusedMLPlazily creates its fused implementation during the first forward.The previous implementation captured descendant hook objects only once at that
point. Distributed optimizer training can temporarily disable its parameter
gather hooks for the first iteration and enable them afterward, leaving the
fused implementation with an empty or stale snapshot. Subsequent forwards then
skip the current DDP hooks.
This change:
fused implementation;
TEFusedMLPitself, since normaltorch.nn.Module.__call__already executes those hooks;input-modifying pre-hooks; and
implementation construction.
Validation
4-rank jobs: both parameterizations passed on both nodes.
op fuser: completed successfully.
both changed files.