fix(tensor-parallel): AUT-1177 deduplicate expert shards by expert TP - #6165
Queued
svcnemo-autobot wants to merge 2 commits into
Queued
fix(tensor-parallel): AUT-1177 deduplicate expert shards by expert TP#6165svcnemo-autobot wants to merge 2 commits into
svcnemo-autobot wants to merge 2 commits into
Conversation
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Contributor
|
/ok to test e2dc53a |
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Contributor
|
/ok to test af91b6b |
yaoyu-33
approved these changes
Jul 31, 2026
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/30646819346 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Megatron-Bridge dev validation PR NVIDIA-NeMo/Megatron-Bridge#5174 exposed that MCore dev dropped expert-TP-aware duplicate filtering, causing expert parameter norm failures.
What changed
allreduce=Falseparameters through the expert TP group.Details
flowchart LR P[Parameter] --> A{allreduce?} A -->|false| E[Expert TP group] A -->|true| T[Regular TP group] E --> D[Duplicate filter] T --> DThe commit is based directly on Bridge's pinned dev SHA
95e4bafebaa799d166975ef82066a3c46648e004. Bridge PR #5174 will temporarily validate this PR head; the temporary pin will be replaced by the merged dev commit before Bridge lands.Tested