Skip to content

fix(tensor-parallel): AUT-1177 deduplicate expert shards by expert TP - #6165

Queued
svcnemo-autobot wants to merge 2 commits into
NVIDIA:devfrom
svcnemo-autobot:fix/expert-tp-duplicate-filter-260730
Queued

fix(tensor-parallel): AUT-1177 deduplicate expert shards by expert TP#6165
svcnemo-autobot wants to merge 2 commits into
NVIDIA:devfrom
svcnemo-autobot:fix/expert-tp-duplicate-filter-260730

Conversation

@svcnemo-autobot

Copy link
Copy Markdown
Collaborator

Background

Megatron-Bridge dev validation PR NVIDIA-NeMo/Megatron-Bridge#5174 exposed that MCore dev dropped expert-TP-aware duplicate filtering, causing expert parameter norm failures.

What changed

  • Route allreduce=False parameters through the expert TP group.
  • Preserve regular TP behavior for dense parameters.
  • Add focused coverage for both paths.

Details

flowchart LR
 P[Parameter] --> A{allreduce?}
 A -->|false| E[Expert TP group]
 A -->|true| T[Regular TP group]
 E --> D[Duplicate filter]
 T --> D
Loading

The commit is based directly on Bridge's pinned dev SHA 95e4bafebaa799d166975ef82066a3c46648e004. Bridge PR #5174 will temporarily validate this PR head; the temporary pin will be replaced by the merged dev commit before Bridge lands.

Tested

  • isort, Black, and Ruff checks passed.
  • Focused regression: 4 passed.
  • Complete eight-rank tensor-parallel module: 7 passed on the same logic before a formatter-only amendment.

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
@svcnemo-autobot
svcnemo-autobot requested review from a team as code owners July 31, 2026 01:14
@copy-pr-bot

copy-pr-bot Bot commented Jul 31, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

/ok to test e2dc53a

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

/ok to test af91b6b

@yaoyu-33
yaoyu-33 added this pull request to the merge queue Jul 31, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/30646819346

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants