-
Notifications
You must be signed in to change notification settings - Fork 266
Add F3 payload layer: receiver-confirmed completion, receiver budgets, awaitable transfer facade #4865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
YuanTingHsieh
wants to merge
18
commits into
NVIDIA:main
Choose a base branch
from
YuanTingHsieh:yuantingh/client-api-f3-outcome-hardening
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,647
−470
Open
Add F3 payload layer: receiver-confirmed completion, receiver budgets, awaitable transfer facade #4865
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
6453e33
Harden outcome recording: registration order, required guard, deep-fr…
YuanTingHsieh 51ca37d
Design/plan updates: heartbeat phases, per-launch tokens, dependencie…
YuanTingHsieh ce4e95a
Add F3 payload layer: receiver-confirmed completion, receiver budgets…
YuanTingHsieh d941683
Simplify F3 payload layer: hot-path trims, tx-level acquisition, shar…
YuanTingHsieh e85d773
Remove the implementation-plan doc; design doc stands alone
YuanTingHsieh a98d74a
Fold design rev 2.2, protocol vocabulary, and plan removal into the F…
YuanTingHsieh 4ff559c
Rename _tx_incarnations to _outcome_owners; owner language throughout
YuanTingHsieh 5647cca
Remove plan-id tags from comments and docstrings
YuanTingHsieh ea7a181
Enforce receiver identities; bind confirmations to serves; settle bef…
YuanTingHsieh f37816f
Enforce receiver identities; bind confirmations to serves; settle bef…
YuanTingHsieh 38d56d9
Make settlement exception-proof; close the mid-settlement supersede gap
YuanTingHsieh 70d5709
Serialize tx_id generations instead of flag-gating superseded emissions
YuanTingHsieh 01be4c0
Drain in-flight operations before settlement; bound live-retirement w…
YuanTingHsieh 11f19a0
Drain waiters parked during the shutdown settlement window
YuanTingHsieh 5c5d76a
Make tx_ids attempt-scoped: reject duplicates instead of serializing …
YuanTingHsieh dc901fb
Keep a drain-leaked tx_id excluded until its operations exit
YuanTingHsieh ee15305
Trim comments to constraint-only; one home per invariant
YuanTingHsieh 246d11b
Close the shutdown window on drain-leaked tx_ids; review polish
YuanTingHsieh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| # Copyright (c) 2026, NVIDIA CORPORATION. All rights reserved. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| """DIRECTORY-WIDE fixtures: the autouse fixture below applies to EVERY test in | ||
| tests/unit_test/fuel/f3/streaming/, including tests that never touch confirms. | ||
| A new test here never exercises the real ConfigService read of the confirm | ||
| kill-switch; patch _receiver_confirm_cached explicitly if you need the legacy | ||
| (confirm-off) path or the real config read.""" | ||
|
|
||
| from unittest.mock import patch | ||
|
|
||
| import pytest | ||
|
|
||
| from nvflare.fuel.f3.streaming import download_service as ds_module | ||
|
|
||
|
|
||
| @pytest.fixture(autouse=True) | ||
| def confirm_switch_on(): | ||
| """Pin the receiver-confirm kill-switch ON for all streaming tests. | ||
|
|
||
| Individual tests patch it OFF explicitly; legacy-path tests are unaffected (their | ||
| requests carry no capability key, so the switch is never consulted for them). | ||
| """ | ||
| with patch.object(ds_module, "_receiver_confirm_cached", True): | ||
| yield |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.