Skip to content

fix(nv_build): cover reported model metadata#279

Open
rodboev wants to merge 1 commit into
NVIDIA:mainfrom
rodboev:pr/nv-build-model-registry
Open

fix(nv_build): cover reported model metadata#279
rodboev wants to merge 1 commit into
NVIDIA:mainfrom
rodboev:pr/nv-build-model-registry

Conversation

@rodboev

@rodboev rodboev commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary

The nv_build provider now resolves bundled metadata for the current NVIDIA endpoint IDs that can be proved from owner docs. This prevents confirmed GLM entries from falling through to SkillSpector's generic 128,000-token budget while keeping short-form or unproved labels unresolved.

Refs #129

Root cause

The nv_build provider uses exact keys from its bundled YAML registry. The reported models had no entries under their NVIDIA endpoint IDs, so metadata returned None and model budgeting used the generic fallback. deepseek-ai/deepseek-v4-flash is already present and remains unchanged, while the issue's short-form labels are not nv_build endpoint IDs and some reported models are not owner-proved as current NVIDIA endpoints.

Diff Notes

  • add only owner-confirmed current nv_build model IDs
  • add parameterized exact-lookup coverage for every retained entry and every retained field
  • preserve unknown-model fallback and reject short-form or unproved near-match aliases

Scope

This change does not alter model defaults, provider creation, retry behavior, shared registry lookup, alias normalization, or other provider registries. The short labels as written in the issue (glm-5.2, glm-5.1, kimi-k2.7-code, deepseek-v4-flash) still resolve no metadata; nv_build keys entries by exact NVIDIA endpoint ID and this change adds no alias layer. It also does not invent a mapping for kimi-k2.7-code unless current owner docs prove that exact NVIDIA endpoint, and it leaves the issue's mimo-v2.5 and minimax-m3 CI deadlock reports unaddressed, so the issue stays open for those. It makes no claim that local metadata tests prove live inference success.

Verification

  • uv sync --all-extras - completed successfully; installed the project and 151 packages
  • uv run pytest tests/unit/test_providers.py -k "NvBuildProvider" - 14 passed, 62 deselected in 1.17s
  • uv run pytest tests/unit/test_providers.py -k "nv_build and reported_model" - 3 passed, 73 deselected in 0.98s
  • uv run pytest tests/unit/test_providers.py -k "nv_build and model_near_match" - 2 passed, 74 deselected in 0.99s
  • uv run pytest tests/unit/test_providers.py -k "NvBuildProvider and metadata_known_model" - 1 passed, 75 deselected in 1.02s
  • uv run ruff check src/ tests/ - All checks passed!
  • uv run ruff format --check src/ tests/ - 144 files already formatted

Signed-off-by: Rod Boev <rod.boev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant