feat(provider): forward reasoning effort to OpenAI-compatible models#285
Open
rodboev wants to merge 1 commit into
Open
feat(provider): forward reasoning effort to OpenAI-compatible models#285rodboev wants to merge 1 commit into
rodboev wants to merge 1 commit into
Conversation
…VIDIA#283) Signed-off-by: Rod Boev <rod.boev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SkillSpector can now forward an explicit reasoning-effort setting through its OpenAI-compatible LLM path instead of always relying on the provider or gateway default.
Closes #283
Implements the maintainer-scoped sketch in #283.
Root cause
The shared OpenAI-compatible constructor always built
ChatOpenAIwith a fixed kwarg set, so neither the stock OpenAI wrapper nor the nv_build wrapper had a path to forward reasoning effort. The env-var docs also had no setting for this override, which left the behavior undiscoverable even for compatible endpoints.Diff Notes
SKILLSPECTOR_REASONING_EFFORTforwarding in the shared OpenAI-compatible constructor pathScope
This change stays in the OpenAI-compatible provider adapter path. It does not add provider-specific validation, native Anthropic support, Bedrock-specific handling, or CLI-provider changes. Unsupported provider/model combinations still fail wherever the upstream provider rejects the forwarded value.
Verification
uv sync --all-extraspassed; installed the project and 151 packages.7 passed, 69 deselected.uv run pytest tests/unit/test_providers.py -k "reasoning_effort_"passed; pytest reported6 passed, 71 deselected.uv run ruff check src/ tests/passed withAll checks passed!.uv run ruff format --check src/ tests/passed with144 files already formatted.