test: add CPU-only unit coverage for sharding helpers#3250
Open
Pritiks23 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Pritika Vipin <65793273+Pritiks23@users.noreply.github.com>
Author
|
This PR adds CPU-only unit coverage for sharding helper logic used during pytest test selection, without changing any kernel/runtime behavior. What is covered: Marker argument parsing/defaulting/validation via mark_values The sharding helper code influences which tests run or skip in CI |
Author
|
Hi maintainers — PR is ready for review. I’m happy to iterate on feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
test/utils/test_sharding.py contains core test-selection logic used by pytest sharding flows, but helper-level behavior had no direct unit coverage. These tests harden that logic without requiring CUDA or GPU runtime.
Validation
Notes