Skip to content

Fix panama headers when RAPIDS_VERSION points to a PR branch #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
imotov wants to merge 6 commits into from
+22 −21
Closed

Fix panama headers when RAPIDS_VERSION points to a PR branch #185

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e95eee3
Fix panama headers when RAPIDS_VERSION points to a PR branch
imotov Jul 28, 2026
13fba23
Fix RAPIDS_BRANCH
imotov Jul 28, 2026
d7b3973
Move handling of PRs into ci/build.sh
imotov Jul 28, 2026
d52f444
Fix conda remove command
imotov Jul 28, 2026
e42bee6
Fix RAPIDS_BRANCH
imotov Jul 29, 2026
941e78a
Merge branch 'release/26.08' into fix-panama-compilation-in-cuvs-pr-pull
imotov Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,13 @@ if hasArg --build-cuvs-java; then
LD_LIBRARY_PATH="$LIBCUVS_DIR/lib${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}"
export LD_LIBRARY_PATH
echo "LD_LIBRARY_PATH is: $LD_LIBRARY_PATH"
# Point cmake to the PR artifact so find_package(cuvs) picks up its headers
# instead of the conda-installed ones, ensuring jextract generates correct
# Panama bindings for any new C API in the PR.
export CMAKE_PREFIX_PATH="$LIBCUVS_DIR"
# Uninstall the conda-installed libcuvs so it cannot shadow the PR artifact
# at runtime.
conda remove --yes --force-remove libcuvs

@KyleFromNVIDIA KyleFromNVIDIA Jul 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the reasoning, but I'm hesitant to have a build.sh that modifies the environment in this manner. Perhaps it would be better to export cuvs_ROOT instead.

fi
./build.sh "${CUVS_BUILD_TARGETS[@]}"
popd
Expand Down