-
Notifications
You must be signed in to change notification settings - Fork 216
Use librtcx for JIT-LTO #2311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arhag23
wants to merge
16
commits into
NVIDIA:main
Choose a base branch
from
arhag23:use-librtcx
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Use librtcx for JIT-LTO #2311
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
8b96c0c
use librtcx for jit-lto
arhag23 18b142b
link tests against rtcx
arhag23 1433624
Add missing rtcx dependencies
arhag23 1fa0379
Resolve librtcx not properly exporting private static link dependencies
arhag23 42fd2e9
Fix missing nvrtc/nvjitlink
arhag23 6e2026d
Fix test now that rtcx throws std:: exceptions
arhag23 53ee371
Install rtcx to fix python and other builds
arhag23 cd09d1b
rtcx marks libzstd_static as global target
arhag23 4cfa810
rtcx is a cuvs-static export only
arhag23 dc3e0c7
properly handle rtcx libzstd static
arhag23 e413021
Also link against nvrtc_builtins
arhag23 7d98976
update actions/checkout to fix zizmor
arhag23 0bb2fd6
Merge remote-tracking branch 'upstream/main' into use-librtcx
arhag23 0575566
Test against upstream librtcx
arhag23 a49fb8c
cleanup comment
arhag23 5afd5dc
Merge remote-tracking branch 'upstream/main' into use-librtcx
arhag23 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| #============================================================================== | ||
| # cmake-format: off | ||
| # SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # cmake-format: on | ||
| #=============================================================================- | ||
|
|
||
| # This function finds rtcx | ||
| function(find_and_configure_rtcx VERSION) | ||
|
|
||
| # Ensure rtcx installs its targets unconditionally. In shared builds the static library is | ||
| # absorbed into libcuvs.so, but CMake still requires the target to be in an export set for | ||
| # install(EXPORT) validation. In static builds consumers need to link librtcx.a directly. | ||
| set(RTCX_INSTALL ON) | ||
|
|
||
| include("${rapids-cmake-dir}/cmake/default_install_component.cmake") | ||
| rapids_cmake_default_install_component(DEFAULT_USE_PROJECT_NAME) | ||
|
|
||
| rapids_cpm_find( | ||
| rtcx ${VERSION} | ||
| GLOBAL_TARGETS rtcx::rtcx | ||
| BUILD_EXPORT_SET cuvs-static-exports | ||
| INSTALL_EXPORT_SET cuvs-static-exports | ||
| CPM_ARGS | ||
| GIT_REPOSITORY https://github.com/rapidsai/librtcx | ||
| GIT_TAG b5e753e9427e331c02f8c370143cb0d5f40da0fd | ||
| GIT_SHALLOW FALSE | ||
| ) | ||
|
|
||
| # When CPM fetches from source (add_subdirectory), generate_jit_lto_kernels.cmake is not | ||
| # auto-included. Include it explicitly so necessary functions are available. | ||
| if(rtcx_ADDED OR DEFINED CPM_rtcx_SOURCE) | ||
| include("${rtcx_SOURCE_DIR}/generate_jit_lto_kernels.cmake") | ||
| endif() | ||
| endfunction() | ||
|
|
||
| set(RTCX_MIN_VERSION_cuvs "0.1") | ||
| find_and_configure_rtcx(${RTCX_MIN_VERSION_cuvs}) |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.