feat: narrow probe selection by intent: in run.spec - #2113
Open
patriciapampanelli wants to merge 5 commits into
Open
feat: narrow probe selection by intent: in run.spec#2113patriciapampanelli wants to merge 5 commits into
patriciapampanelli wants to merge 5 commits into
Conversation
Signed-off-by: Patricia Pampanelli <ppampanelli@nvidia.com>
Signed-off-by: Patricia Pampanelli <ppampanelli@nvidia.com>
Signed-off-by: Patricia Pampanelli <ppampanelli@nvidia.com>
Signed-off-by: Patricia Pampanelli <ppampanelli@nvidia.com>
Signed-off-by: Patricia Pampanelli <ppampanelli@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
intent:inrun.specwas accepted but had no effect on probe selection. This PR makes it filter:intent:/-intent:now narrow the candidate set by intent typology descendancy.Design decisions
intent:(include) and-intent:(exclude) filter symmetrically.IntentProbesubclasses (no fixedintent) are pruned only if every included code is explicitly blocked for that probe; otherwise they're kept, since which intents they actually serve is decided later, at generation time.intent:code is rejected and reported (e.g. on--list_probes/--list_buffs), not silently dropped.Verification
garak --list_probes --spec probes.lmrc,intent:S005hate— onlylmrc.SlurUsagewas listed (leaf code, siblingS005bullyexcluded).garak --list_probes --spec probes.dan,-intent:T009— printedNo probes match the provided filter(all activedan.*declareT009ignore).garak --target_type test.Blank --spec probes.grandma.GrandmaIntent,intent:S005bully— ran to completion with no warning, produced evaluated results.garak --target_type test.Blank --spec probes.dan.AutoDANCached,intent:T009ignore— no warninggarak --list_probes --spec probes.dan,intent:zzz— printed a "skipped selector" notice forintent:zzzand still listed the fulldan.*family.garak --target_type test.Blank --spec probes.lmrc,intent:M010degrade— aborted with a message namingM010degradeas the code nothing matched.garak --list_probes --spec probes.lmrc,intent:S005hate --probe_tags avid-effect:performance:P0401— onlylmrc.SlurUsagewas listed; the deprecated tag was ignored.probes.*at all (default candidate = the whole active registry):garak --list_probes --spec intent:S005hate— 3 probes across 3 different modules (continuation,grandma,lmrc), not one family.garak --list_probes --spec=-intent:T009— every active probe declaringT009ignore(acrossdan,goodside, and others) dropped out.garak --list_probes --spec intent:S005,-intent:S005hate,tier:1— mixed include+exclude plus atier:filter narrowed to a single probe.Closes #1873