-
Notifications
You must be signed in to change notification settings - Fork 115
Add nvbench-compare-robust --plot-output/--plot-along-output options #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
oleksandr-pavlyk
wants to merge
13
commits into
NVIDIA:main
Choose a base branch
from
oleksandr-pavlyk:add-explicit-plot-output-options-in-compare-script
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
2df385f
Add nvbench-compare-robus --plot-output/--plot-along-output options
oleksandr-pavlyk 9e1f477
Fix review feedback
oleksandr-pavlyk 0a2f954
Add second iteration review feedback
oleksandr-pavlyk 75b9119
Address feedback
oleksandr-pavlyk 23fe997
Merge branch 'main' into add-explicit-plot-output-options-in-compare-…
oleksandr-pavlyk e37d351
Move plotting functionality out, compare_benches no longer owns plot-…
oleksandr-pavlyk a441f70
Add type annotations for internal functions/structures
oleksandr-pavlyk 48cdc06
Expand nvbench_compare_robust to mention bulk-debug-python use for cu…
oleksandr-pavlyk b91ddd3
Merge remote-tracking branch 'upstream/main' into add-explicit-plot-o…
oleksandr-pavlyk b07ca0b
Validate that all requested plots use same output mode
oleksandr-pavlyk d5d5fe5
Implement disambiguation on output filename collision
oleksandr-pavlyk e5f83bd
Add comments
oleksandr-pavlyk 16e5ed8
Reject --plot-output '' explicitly
oleksandr-pavlyk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{pair}is the zero-based index of(reference_device_id, compare_device_id)pairs that specification of--reference-devices/--compare-devicesimplies as specified. For example, specifying--reference-devices 0,1 --compare-devices 0,0, the pair (0, 0)would have index0, and the pair(1, 0)would have index1.